Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional logging when overflow occurs in calculate_stake_rew… #3783

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roryharr
Copy link

Problem

Currently unwrap is used during calculate_stake_rewards, this lead to a lack of logging when an overflow occurs.

It might be better to take an action other than panic!, but it matches the current code and it's not clear to me what other action should be taken.

Summary of Changes

Additional logs during overflow calculations during calculate_stake_rewards
No change of functionality, validated through new unit tests.

Fixes #

Copy link

mergify bot commented Nov 25, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant