Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract inner-instruction crate #3351

Closed

Conversation

kevinheavey
Copy link

Problem

solana_sdk::inner_instruction imposes a solana_sdk dep on solana_svm, solana_transaction_status and solana_banks_interface

Summary of Changes

  • Move to its own crate and re-export with deprecation notice
  • Make serde optional in the new crate

@kevinheavey kevinheavey force-pushed the extract-inner-instruction branch from 738fd87 to b69c77c Compare December 3, 2024 00:13
@kevinheavey kevinheavey requested a review from febo December 4, 2024 16:05
@febo
Copy link

febo commented Dec 5, 2024

Since the InnerInstruction is a wrapper type over CompiledInstruction, would it make sense to add it solana-message instead? We could have it behind a feature flag if that is more appropriate – they seem quite coupled.

cc: @joncinque

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants