forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wen_restart: Add wen_restart_coordinator argument. #2975
Merged
wen-coding
merged 6 commits into
anza-xyz:master
from
wen-coding:wen_restart_add_coordinator
Oct 8, 2024
Merged
wen_restart: Add wen_restart_coordinator argument. #2975
wen-coding
merged 6 commits into
anza-xyz:master
from
wen-coding:wen_restart_add_coordinator
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
reviewed
Oct 4, 2024
wen-restart/src/wen_restart.rs
Outdated
@@ -1333,6 +1334,7 @@ mod tests { | |||
const TICKS_PER_SLOT: u64 = 2; | |||
const TOTAL_VALIDATOR_COUNT: u16 = 20; | |||
const MY_INDEX: usize = TOTAL_VALIDATOR_COUNT as usize - 1; | |||
const LEADER_INDEX: usize = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: COORDINATOR_INDEX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
carllin
previously approved these changes
Oct 4, 2024
carllin
approved these changes
Oct 8, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* wen_restart: Add wen_restart_coordinator argument. * rename LEADER_INDEX with COORDINATOR_INDEX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wen_restart_coordinator, this is the leader we use in HeaviestFork phase.