Retire stable-rust clippy for still buggy redundant_clone #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
changed the title
yihau
reviewed
Jun 10, 2024
There was a problem hiding this comment.
thank you for bumping this up! it's good to see this one happen! could we have these modifications in this PR as well?
- delete
./scripts/cargo-clippy-stable.sh. I think no one will use it anymore 🤔 - removed these lines in the
.mergify.ymlLines 64 to 66 in 5263c9d
ryoqun
commented
Jun 10, 2024
| @@ -60,13 +60,9 @@ pull_request_rules: | |||
| - status-success=build & deploy docs | |||
| - or: | |||
| - -files~=(\.rs|Cargo\.toml|Cargo\.lock|\.github/scripts/cargo-clippy-before-script\.sh|\.github/workflows/cargo\.yml)$ | |||
| - and: | |||
There was a problem hiding this comment.
according to https://docs.mergify.com/configuration/conditions/, i think we can also remove this and: because it would only have a single or.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
the clippy lint called
redundant_clonegot buggy in the past.As a work around, we enabled stable clippy along side nightly clippy, to avoid back-port churns. that worked because we used non-buggy clippy from older rust toolchain at the time in the target backport branches, instead of disabling the useful
redundant_cloneacross the board.ref: solana-labs#31834
Summary of Changes
after 1 year,
redundant_cloneisn't fixed upstream yet. it's effectively disabled by being put under the nursery category of lints (since v1.71.0, rust-lang/rust#113417). now that, the lint is disabled across all of our active branches (master, v1.18, v1.17).we have no choice but can't enable
redundant_cloneand this is true across board.in a say, the situation is a
redundant_clippy. lol. well well, this is such a life. we disable the dual clippy for faster ci with tears.