wayvncctl events #178
Merged
wayvncctl events #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Valgrind looks good; no leaks. Manual testing looks good too. |
any1
reviewed
Nov 12, 2022
| connection_count_now "$count" | ||
| ;; | ||
| esac | ||
| done < <("$WAYVNCCTL" --json event-receive) |
There was a problem hiding this comment.
Might be convenient to have an option to write the response to an environment variable so you can skip the read.
There was a problem hiding this comment.
Trying to think of how we can do that.
One idea I had was to introduce a "script mode" where a user could run wayvncctl --event-script=/path/to/executable and then we would run that executable once for every event, with some reasonable calling convention that puts the event details in the env and/or cmdline. But I think I'd want to do that in a separate PR.
Once we start enqueueing asynchronous events, it's more important to send fatal errors (which then disconnect) imediately by prepending them to the send queue. Everything else is still processed FIFO. Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Includes "client-connect" and "client-disconnect" events as proof-of-concept. Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
lack
force-pushed
the
wayvncctl-events
branch
from
42c96b4 to
9df8bc7
Compare
|
Thanks! |
This was referenced Nov 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds server->client broadcast events
Read wayvnc.scd and wayvncctl.scd for an overview.
I have read and understood CONTRIBUTING.md and its associated documents.