-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wayvncctl #171
wayvncctl #171
Conversation
76a4a08
to
63858a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quality here is well above average when it comes to code I've reviewed for this project.
I did not have time today to look at this as thoroughly as I would have liked and I may have missed important details.
Overall, I would like to see the log level dropped a little bit. There is an nvnc_trace()
macro which I feel is underutilised.
2bf3ddb
to
b6dbc84
Compare
ceba956
to
12707d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready!
373825e
to
8c13cc5
Compare
Okay! Tested most code paths with valgrind and fixed some refcount-based leaks. @any1 : ready for another review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after a few final tweaks.
Signed-off-by: Jim Ramsay <[email protected]>
This implements the first wayvncctl command: set-output Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Also adds the '--json' option to produce machine-readable output. Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
@any1 Done! Also fixed a handful of |
Thanks! |
I have read and understood CONTRIBUTING.md and its associated documents.