Multi-output: part 1 - internal functions to cycle between outputs #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lack
force-pushed
the
output_switching
branch
from
d639577 to
a4c65d6
Compare
lack
changed the title
any1
requested changes
Oct 11, 2022
Additionally, make the pointer setup reentrant, destroying the previous setup if needed. Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
One to switch to an arbitrary outout, and then two helpers to switch to the next/previous in the output list. Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
lack
force-pushed
the
output_switching
branch
from
a4c65d6 to
e414aa8
Compare
any1
approved these changes
Oct 12, 2022
| iter->next : iter->prev; | ||
| } | ||
| struct output* output; | ||
| return wl_container_of(iter, output, link); |
There was a problem hiding this comment.
I think you can just as well say wl_container_of(iter, struct output, link) here.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of multi-output displays (#112), this changeset does some internal refactoring to support switching capture and pointer input to other outputs while a client is connected.
I have read and understood CONTRIBUTING.md and its associated documents.