This repository has been archived by the owner on Feb 25, 2019. It is now read-only.
UserInfo update #303
Merged
UserInfo update #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not ready to merge. We need to review and ensure the endpoint is properly mapping from OIDC |
|
As I was working on the tests for this, it occurred to me again that we don't have a good way to delete properties, etc. On researching how other APIs deal with this sort of thing I discovered RFC6902. Before merging, I think we should consider this type of scheme for this endpoint and all the PATCH endpoints in the REST API. |
|
I've created a new issue for RFC6902 JSON Patch API and will merge this now. Thanks @EternalDeiwos for getting the ball rolling on this requirement. Great work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.