-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Hyprpaper #7
Comments
Hi, while Hyprland user myself, I have several problems with hyprpaper. Basically, this tool is very different from all other wallpaper tools, and frankly is pretty weird! For example, "A Wallpaper cannot be applied without preloading. The config is not reloaded dynamically". So, there are a few problems it creates:
So, as far as I understand, hyprpaper is a truly minimalist tool for loading specific wallpapers to specific workspaces at the start of Hyprland and is not really meant to change wallpapers on the flight. If I misunderstand something here, please correct me :) |
@anufrievroman You can use hyprctl hyprpaper preload /path/to/wallpaper
hyprctl hyprpaper wallpaper MONITOR,/path/to/wallpaper
hyprctl hyprpaper unload /path/to/wallpaper
|
I'm currently doing this with scripts, but I wanted a GUI to select the wallpaper. |
Hmm, that's interesting, thank you, I'll take a look then. But, this will only work on hyprland, right? I mean only when |
Perhaps no one use hyprpaper in other window manager or desktop environment |
I tested it a bit, and so far I see a few problems:
If anyone has any comments, especially about first two issues, please :) |
I'm also waiting for it, you could try to ask the devs of hyprland maybe they can implement it or make a pull request yourself. |
It is possible, of course, to work with |
It may well be because of the name, it seems like it is the package was supposed to be used on hyprland, and also everybody seems to be willing to lose their time trying to figure out a way to use it with hyprpaper rather than just switch to one of those. Who will understand the human being! |
Thanks to @nikolaizombie1 preliminary work to make
|
Hello and thank you accepting my pull request @anufrievroman .
I just created a new pull request separating the
This is correct. hyprpaper only supports display names and images, no fill options or colors.
This isn't strictly necessary. Although the |
I see, okay. Thank you very much for PR, sorry I wasn't able to check it today, I'll try to get to it as soon as I can. |
It's all good. You can check on them whenever you can. Also I did some more research and there are some options that cannot be set using
At the very least a note in the should be added that that these options are only available in the config file. |
Thank you again for the latest commits, it seems to work, but for me it does not really work "out of the box", I'm getting some hyprpaper error and I wonder if that just lacks this library, or it's something else:
|
That’s odd. What distribution are you using to run hyprland and hyprpaper? I did my testing on Arch and it worked fine. I’m going to test it on Nixos tomorrow and see if I can replicate the error. |
Actually it turned out to be a global problem on my system, so disregard. |
So, now the
which I suppose is a common issue with I investigated and if I create a proper config of
So, without IPC, the changing wallpaper vie |
On the sidenote, I noticed that while |
This would be great to document in a troubleshooting section of the README. A user might encounter the same problem and think that
I see, having inter process communication (IPC) enabled is required for
I will quickly implement this fix as well. |
Also, if I understood correctly, currently, we are preloading and setting wallpapers but never unloading them, so the hyprpaper just keeps them in RAM. I guess after setting new wallpaper we can try to unload previous wallpaper for the given monitor. Is it just |
This hides fill and color options on hyprpaper, as discussed in #7
Kill the hyprpaper deamon if we switched to swww to avoid the conflict. Discussed in #7
This is to unload old wallpapers from RAM when the new wallpaper is set, as discussed in #7
I did the Edit: Personally, I always have this issue with hyprpaper. Supposed to be fixed in the next version. |
Will do. |
Finally, I made it work (with all the updates of all systems), but the only remaining issue that I experience is that the wallpaper changes only if I select the monitor (eDP-1), while if I keep it "All" the wall paper does not change. Does it work for you? In the code everything seems fine, we set it as "" if monitor is "All", so it should work... Edit: I tested and basically command |
As far as I remember it did function correctly but I'll check first thing tomorrow and see if it works as intended. |
I did more testing on another machine and with multiple monitors. Basically, sometimes it works, sometimes it fails randomly. I think at least part of the problem is that I often get ICP message that:
This probably means that it has not enough time to preload. So, we should either increase sleep time, or even better, somehow make sure that it's preloaded before requesting the change. Maybe we can simply sequence preload |
I've tracked down the source of the bug. Here are the steps to reproduce:
The bug is caused by Edit: I raised the issue with |
A |
Thank you for investigation! I see, it's weird but okay, if Vaxry says so ¯\_(ツ)_/¯. Then yes, let's just remove All from options. I'll try to look into it today or tomorrow. If you know how to do it (it's when we check for available monitors) feel free to add it to the current PR. |
Thanks to all the efforts by @nikolaizombie1 I am happy to announce that hyprpaper support seems to be fully functional in current main branch. I'll make some minor refactoring and we can publish this release 🎉 |
Any ETA on support for Hyprpaper?
The text was updated successfully, but these errors were encountered: