Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move g from deps to devdeps #25

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: move g from deps to devdeps #25

merged 1 commit into from
Apr 9, 2024

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Apr 8, 2024 •
edited
Loading

@antv/g 应该作为 plot 的 devDeps

ai-qing-hai
ai-qing-hai approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@ai-qing-hai ai-qing-hai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不再使用 @antv/g 创建元素，使用 context 创建。

@ai-qing-hai ai-qing-hai merged commit 9ad51a2 into master Apr 9, 2024
2 checks passed
@ai-qing-hai ai-qing-hai deleted the fix-plot branch April 9, 2024 01:38
@nekronhuang
Copy link

改好了，要不。。。发一下？

目前0.2.0还是有这个依赖的，因为没声明 g 的版本，应用依赖复杂的话，不保证没问题。。

@hustcc
Copy link
Member

hustcc commented Jun 26, 2024

@ai-qing-hai 帮忙发一个版本吧！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ai-qing-hai ai-qing-hai ai-qing-hai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaoiver @nekronhuang @hustcc @ai-qing-hai