Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 can not select flat edge #1394

Merged
merged 1 commit into from
Oct 1, 2021
Merged

fix: 🐛 can not select flat edge #1394

merged 1 commit into from
Oct 1, 2021

Conversation

NewByVector
Copy link
Contributor

Description

  1. 解决水平、垂直连线无法被选中问题

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. pkg:x6 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #1394 (dd8f2d8) into master (4d0b1e8) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1394   +/-   ##
=======================================
  Coverage   39.22%   39.22%           
=======================================
  Files         601      601           
  Lines       33503    33503           
  Branches     6803     6803           
=======================================
  Hits        13143    13143           
  Misses      19566    19566           
  Partials      794      794           
Flag Coverage Δ
x6 27.01% <20.00%> (ø)
x6-geometry 47.91% <ø> (ø)
x6-vector 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/x6/src/graph/renderer.ts 9.32% <0.00%> (ø)
packages/x6/src/model/model.ts 10.26% <50.00%> (ø)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1295428420

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 1295425723: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@NewByVector NewByVector merged commit 89ae2cc into master Oct 1, 2021
@NewByVector NewByVector deleted the fix-box branch October 1, 2021 16:06
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Oct 1, 2021
github-actions bot pushed a commit that referenced this pull request Oct 1, 2021
## @antv/x6 [1.27.2](https://github.com/antvis/x6/compare/@antv/[email protected]...@antv/[email protected]) (2021-10-01)

### Bug Fixes

* 🐛 can not select flat edge ([#1394](#1394)) ([89ae2cc](89ae2cc))

### Performance Improvements

* ⚡️ improve box selection performance ([#1393](#1393)) ([175aa58](175aa58))
@x6-bot
Copy link
Contributor

x6-bot bot commented Oct 1, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot x6-bot bot added the released PR has released label Oct 1, 2021
@x6-bot
Copy link
Contributor

x6-bot bot commented Oct 12, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot
Copy link
Contributor

x6-bot bot commented Oct 19, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot
Copy link
Contributor

x6-bot bot commented Nov 8, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

bubkoo pushed a commit that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged PR has merged. released PR has released size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
2 participants