feat: support drag canvas on mobile device #6770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request introduces support for dragging the canvas on mobile devices by adapting the mobile offset. It modifies the drag event handling to accommodate mobile-specific interactions. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| if (!this.isDragging) return; | ||
| const { x, y } = event.movement; | ||
| const x = event.movement?.x ?? event.dx; |
There was a problem hiding this comment.
Ensure that event.movement is properly defined for all scenarios, as using event.dx and event.dy as fallbacks might lead to unexpected behavior if movement is not handled correctly for all input types.
Aarebecca
approved these changes
Feb 13, 2025
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support drag canvas on mobile device, which is resolved by adapting the mobile offset
normal.video.mp4