Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reducers may not dispatch actions #1840

Merged
merged 1 commit into from
Dec 24, 2019
Merged

fix: Reducers may not dispatch actions #1840

merged 1 commit into from
Dec 24, 2019

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Dec 24, 2019 •
edited
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

gatsbyjs/gatsby#20082 (comment)

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English none
🇨🇳 Chinese none

☑️ Self Check before Merge

  • All tests pass and/or benchmarks are included
  • Commit message follows commit guidelines
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Dec 24, 2019
tests-checker[bot]
tests-checker bot suggested changes Dec 24, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@simaQ simaQ merged commit b353e4d into master Dec 24, 2019
@simaQ simaQ deleted the fix-gatsby-error branch December 24, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afc163 @simaQ