-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release #1905
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Walkthrough: This pull request introduces new test cases for bug fixes related to issues #1176 and #1882, updates the changelog and package.json for the g-web-components package, and modifies HTML shape handling in the source code. Additionally, it refines the rendering of web components in React and JavaScript demos. Changes:
🪧 TipsFor further assistance, please describe your question in the comments and @petercat-assistant to start a conversation with me. |
const observer = new MutationObserver(() => { | ||
const egl = this.gElement as any; | ||
|
||
function updateHTML(shape: HTMLShape) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored the HTML update logic into a separate function updateHTML
to improve readability and maintainability. Ensure that this change does not introduce any side effects in the rendering process.
@@ -0,0 +1,42 @@ | |||
import { Canvas, Rect } from '@antv/g'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 days ago
To fix the problem, we need to remove the unused Rect
import from the import statement. This will clean up the code and avoid any confusion about unused imports.
- Remove the
Rect
import from the import statement on line 1. - Ensure that the functionality of the code remains unchanged.
-
Copy modified line R1
@@ -1,2 +1,2 @@ | ||
import { Canvas, Rect } from '@antv/g'; | ||
import { Canvas } from '@antv/g'; | ||
import '@antv/g-web-components'; |
No description provided.