Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #1905

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Release #1905

merged 2 commits into from
Feb 8, 2025

Conversation

wang1212
Copy link
Member

@wang1212 wang1212 commented Feb 8, 2025

No description provided.

wang1212 and others added 2 commits February 8, 2025 12:36
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

Walkthrough: This pull request introduces new test cases for bug fixes related to issues #1176 and #1882, updates the changelog and package.json for the g-web-components package, and modifies HTML shape handling in the source code. Additionally, it refines the rendering of web components in React and JavaScript demos.

Changes:

Files Summary
tests/demos/bugfix/1176.ts, tests/demos/bugfix/1882.ts Added new test cases for issues #1176 and #1882.
tests/demos/bugfix/index.ts Exported new test cases for issues #1176 and #1882.
packages/g-web-components/CHANGELOG.md Updated changelog for version 2.0.45 with patch notes.
packages/g-web-components/package.json Updated package version and dependencies.
packages/g-web-components/src/shape/HTML.ts Refactored HTML shape update logic to improve rendering.
site/examples/ecosystem/declarative/demo/web-components-react.tsx, site/examples/ecosystem/declarative/demo/web-components.js Refined web component rendering in React and JavaScript demos.
🪧 Tips For further assistance, please describe your question in the comments and @petercat-assistant to start a conversation with me.

const observer = new MutationObserver(() => {
const egl = this.gElement as any;

function updateHTML(shape: HTMLShape) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored the HTML update logic into a separate function updateHTML to improve readability and maintainability. Ensure that this change does not introduce any side effects in the rendering process.

@wang1212 wang1212 merged commit 2f5d364 into master Feb 8, 2025
4 checks passed
@wang1212 wang1212 deleted the release branch February 8, 2025 06:12
@@ -0,0 +1,42 @@
import { Canvas, Rect } from '@antv/g';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused import Rect.

Copilot Autofix AI 2 days ago

To fix the problem, we need to remove the unused Rect import from the import statement. This will clean up the code and avoid any confusion about unused imports.

  • Remove the Rect import from the import statement on line 1.
  • Ensure that the functionality of the code remains unchanged.
Suggested changeset 1
__tests__/demos/bugfix/1882.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/__tests__/demos/bugfix/1882.ts b/__tests__/demos/bugfix/1882.ts
--- a/__tests__/demos/bugfix/1882.ts
+++ b/__tests__/demos/bugfix/1882.ts
@@ -1,2 +1,2 @@
-import { Canvas, Rect } from '@antv/g';
+import { Canvas } from '@antv/g';
 import '@antv/g-web-components';
EOF
@@ -1,2 +1,2 @@
import { Canvas, Rect } from '@antv/g';
import { Canvas } from '@antv/g';
import '@antv/g-web-components';
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant