New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST API for VPC #80

Merged

reachjainrahul merged 6 commits into main from vpc_REST

Jan 12, 2023

Contributor

bangqipropel commented Dec 14, 2022

Add API for VPC struct
Expose VPC struct in apiserver
Add unit test for the changes introduced

bangqipropel changed the base branch from main to vpc_poller

December 14, 2022 07:48

bangqipropel requested a review from Anandkumar26

December 14, 2022 07:48

Contributor Author

bangqipropel commented Dec 14, 2022

more unit tests can be added tomorrow, and for now, we just compare this branch to vpc_poller now

codecov bot commented Dec 14, 2022 •

edited

Loading

Codecov Report

Merging #80 (0c6c673) into main (34fe66e) will increase coverage by 0.26%.
The diff coverage is 74.33%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   55.70%   55.97%   +0.26%     
==========================================
  Files          48       49       +1     
  Lines        7691     7804     +113     
==========================================
+ Hits         4284     4368      +84     
- Misses       2977     2997      +20     
- Partials      430      439       +9

Flag	Coverage Δ
unit-tests	`55.97% <74.33%> (+0.26%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/apiserver/registry/inventory/rest.go	`74.33% <74.33%> (ø)`

Anandkumar26 reviewed

View reviewed changes

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/vpc_test.go Outdated Show resolved Hide resolved

archanapholla force-pushed the vpc_poller branch 3 times, most recently from 3ec802a to 8d0489a Compare

December 14, 2022 20:47

bangqipropel force-pushed the vpc_REST branch from bf906cc to 89089e9 Compare

December 15, 2022 02:52

bangqipropel requested a review from Anandkumar26

December 15, 2022 02:59

archanapholla force-pushed the vpc_poller branch from 8d0489a to ae2d70d Compare

December 15, 2022 19:35

bangqipropel force-pushed the vpc_REST branch from 89089e9 to 2a80b05 Compare

December 16, 2022 05:08

Anandkumar26 reviewed

View reviewed changes

pkg/apiserver/registry/vpc/rest.go Outdated

+              func (r *REST) Get(ctx context.Context, name string, _ *metav1.GetOptions) (runtime.Object, error) {
+              	ns, ok := request.NamespaceFrom(ctx)
+              	if !ok || len(ns) == 0 {
+              		return nil, errors.NewBadRequest("Namespace cannot be empty.")

Contributor

Anandkumar26 Dec 16, 2022 •

edited

Loading

can the namespace ever be empty?

Contributor Author

bangqipropel Dec 19, 2022

I think when it has some error when requesting from the server, it an be this

Contributor

reachjainrahul Dec 21, 2022

nit: namespace

pkg/apiserver/registry/vpc/rest.go Outdated

+              		return nil, errors.NewBadRequest("Namespace cannot be empty.")
+              	}
+              	objs, found := r.vpcIndexer.ByIndex(cloud.VpcIndexerByName, name)

Contributor

Anandkumar26 Dec 16, 2022

nit:

Suggested change

      
            	objs, found := r.vpcIndexer.ByIndex(cloud.VpcIndexerByName, name)
          
            	objs, err := r.vpcIndexer.ByIndex(cloud.VpcIndexerByName, name)

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

pkg/apiserver/registry/vpc/vpc_test.go Outdated Show resolved Hide resolved

bangqipropel force-pushed the vpc_REST branch 2 times, most recently from dd7a92b to 7a1ea36 Compare

December 19, 2022 20:28

archanapholla force-pushed the vpc_poller branch 2 times, most recently from a6abdcf to 5bc43b4 Compare

December 19, 2022 20:46

bangqipropel closed this

bangqipropel force-pushed the vpc_REST branch from 7a1ea36 to 5bc43b4 Compare

December 19, 2022 20:56

bangqipropel reopened this

archanapholla force-pushed the vpc_poller branch from 5bc43b4 to d6bc12d Compare

December 19, 2022 22:47

bangqipropel force-pushed the vpc_REST branch 2 times, most recently from 6b154ed to fee2085 Compare

December 20, 2022 01:26

archanapholla force-pushed the vpc_poller branch from d6bc12d to f24f620 Compare

December 20, 2022 17:40

bangqipropel force-pushed the vpc_REST branch from fee2085 to 01b6780 Compare

December 20, 2022 20:36

reachjainrahul reviewed

View reviewed changes

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

reachjainrahul reviewed

View reviewed changes

pkg/apiserver/registry/vpc/rest.go Outdated Show resolved Hide resolved

archanapholla force-pushed the vpc_poller branch 2 times, most recently from 7c445fc to d436a70 Compare

December 24, 2022 05:30

archanapholla force-pushed the vpc_poller branch from d436a70 to 1658376 Compare

January 3, 2023 05:26

bangqipropel requested a review from reachjainrahul

January 7, 2023 01:04

bangqipropel force-pushed the vpc_REST branch from ef4ab07 to 6d89017 Compare

January 7, 2023 18:37

archanapholla force-pushed the vpc_poller branch from 2529a9d to fca1bfe Compare

January 7, 2023 20:03

reachjainrahul reviewed

View reviewed changes

pkg/apiserver/registry/inventory/rest.go Outdated Show resolved Hide resolved

archanapholla force-pushed the vpc_poller branch from fca1bfe to fb459d2 Compare

January 8, 2023 05:05

bangqipropel force-pushed the vpc_REST branch from 6d89017 to 466df01 Compare

January 8, 2023 07:08

bangqipropel requested a review from reachjainrahul

January 8, 2023 07:15

reachjainrahul force-pushed the vpc_poller branch 2 times, most recently from 4af7ec3 to 1278b02 Compare

January 9, 2023 05:59

archanapholla force-pushed the vpc_poller branch 2 times, most recently from bf5d87d to bdc1d84 Compare

January 9, 2023 21:29

bangqipropel force-pushed the vpc_REST branch from 466df01 to 3f0bdff Compare

January 9, 2023 21:52

archanapholla force-pushed the vpc_poller branch from bdc1d84 to cae6434 Compare

January 10, 2023 17:20

bangqipropel force-pushed the vpc_REST branch from 3f0bdff to 850f631 Compare

January 10, 2023 18:21

archanapholla force-pushed the vpc_poller branch from cae6434 to 1430a5a Compare

January 11, 2023 04:19

bangqipropel force-pushed the vpc_REST branch from 850f631 to 32520d7 Compare

January 11, 2023 20:35

archanapholla and others added 4 commits

January 11, 2023 15:04


          Implement vpc poller on account add.

63fdf3b

- Perform cloud inventory poll for vpcs on CPA add, vm instanes are skipped
  as configured filters are nil.
- Move account poller(fetches cloud data from internal snapshot) to CPA.
- Account poller is applicable for both vpc and vm instance purpose.
- Maintain vpc list globally using cache indexers.
- In CES, use existing account poller(created during CPA add).
- On CES delete, reset vmSelector filters and skip inventory poll for vms,
  do not distub inventory poll for vpcs.
- On CPA delete, stop cloud inventory poll and remove account poller.
- Add unit test for the changes introduced.
- Add documentation for vpc poller.

Signed-off-by: Archana Holla <[email protected]>


          Fixes for issues.

ce061c7

- Fix for integration test issues
- Improve logging.
- User lower case for some fields in VPC object(follow VM CRD format).

Signed-off-by: Archana Holla <[email protected]>


          Avoid restart account poller on CES add/update

661bb30

- Also remove unwanted files.

Signed-off-by: Anand Kumar <[email protected]>


          Fix for explicitely deleting filters on CPA delete.

1a32e52

Signed-off-by: Archana Holla <[email protected]>

archanapholla force-pushed the vpc_poller branch from 45dfc7a to 1a32e52 Compare

January 11, 2023 23:04


          VPC REST API

d0781aa

Signed-off-by: Bangqi Zhu <[email protected]>

bangqipropel force-pushed the vpc_REST branch from 32520d7 to d0781aa Compare

January 12, 2023 02:24

reachjainrahul changed the base branch from vpc_poller to main

January 12, 2023 13:21


          Merge branch 'main' into vpc_REST

0c6c673

Resolving conflicts
 Conflicts:
	apis/runtime/v1alpha1/vpc_types.go
	pkg/controllers/cloud/account_poller.go
	pkg/controllers/cloud/cloudprovideraccount_controller.go

reachjainrahul approved these changes

View reviewed changes

Contributor

reachjainrahul left a comment

/LGTM

Contributor

reachjainrahul commented Jan 12, 2023

/nephe-test-e2e-aws

reachjainrahul approved these changes

View reviewed changes

Contributor

reachjainrahul left a comment

/LGTM

reachjainrahul merged commit 0e33985 into main

reachjainrahul deleted the vpc_REST branch

January 13, 2023 17:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels