Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perform delta update on aws security rule #34

Merged
merged 5 commits into from
Sep 29, 2022
Merged

perform delta update on aws security rule #34

merged 5 commits into from
Sep 29, 2022

Conversation

shenmo3
Copy link
Contributor

@shenmo3 shenmo3 commented Sep 26, 2022 •
edited
Loading

Description

This PR changes aws security rule update behavior from revoke all then apply all to a delta update, only deleting / adding necessary rules.

Changes

  1. Implement custom comparison function for IpPermissions. Many fields in IpPermission.UserIdGroupPair are not compared due to not used or aws added metadata.
  2. Implement rule delta compute function between new rules and current rules.
  3. Change ingress and egree realization to use add and delete list computed by delta function in authorize and revoke operation.
  4. Added unit test for aws update security rules, coverage for aws 38.5% -> 50.8%.

Signed-off-by: Alexander Liu [email protected]

@shenmo3 shenmo3 self-assigned this Sep 26, 2022
@shenmo3
Copy link
Contributor Author

shenmo3 commented Sep 26, 2022

/nephe-test-e2e-all

@shenmo3
Copy link
Contributor Author

shenmo3 commented Sep 26, 2022 •
edited
Loading

/nephe-test-e2e-eks
Test VPC creation failed, retrying

reachjainrahul
reachjainrahul previously approved these changes Sep 27, 2022
View reviewed changes
@reachjainrahul
Copy link
Contributor

/LGTM

@reachjainrahul
Copy link
Contributor

/LGTM

@reachjainrahul reachjainrahul merged commit 8a0f4b4 into antrea-io:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reachjainrahul reachjainrahul reachjainrahul approved these changes

Assignees

@shenmo3 shenmo3

Labels
kind/release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenmo3 @reachjainrahul