Avoid retrying while syncing security groups #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/nephe-test-e2e-kind |
|
/nephe-test-e2e-kind |
1 similar comment
|
/nephe-test-e2e-kind |
Nephe runs periodic sync with cloud routine to sync cloud entity with internal cache. If any error occurs while syncing cloud entities, we want to avoid adding the entity in retry queue. This is to avoid unneccessary retries if sync with cloud fails, as it itself is another retry mechanism. With this PR, we mantain a new state on cloud entity to indicate if that entity is eligibile for retry if any error occurs. Signed-off-by: Rahul Jain <[email protected]>
shenmo3
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nephe runs periodic sync with cloud routine to sync cloud entity with internal cache. If any error occurs while syncing cloud entities, we want to avoid adding the entity in retry queue. This is to avoid unnecessary retries if sync with cloud fails, as it itself is another retry mechanism.
Changes
With this PR, we maintain a new state on cloud entity to indicate if that entity is eligible for retry if any error occurs.