Support rule appliedTo in Antrea NetworkPolicy #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/nephe-test-e2e-kind, /nephe-test-e2e-aws, /nephe-test-e2e-azure |
|
/nephe-test-e2e-eks, /nephe-test-e2e-aks |
|
/nephe-test-e2e-aws |
|
/nephe-test-e2e-aws |
| var err error | ||
| nps, err = r.networkPolicyIndexer.ByIndex(networkPolicyIndexerByAppliedToGrp, s.id.Name) | ||
| if err != nil { | ||
| return fmt.Errorf("get networkpolicy indexer with index=%v, name=%v: %w", networkPolicyIndexerByAppliedToGrp, s.id.Name, err) |
There was a problem hiding this comment.
nit:
Suggested change
| return fmt.Errorf("get networkpolicy indexer with index=%v, name=%v: %w", networkPolicyIndexerByAppliedToGrp, s.id.Name, err) | |
| return fmt.Errorf("get networkpolicy indexer with index=%v, name=%v: %v", networkPolicyIndexerByAppliedToGrp, s.id.Name, err) |
There was a problem hiding this comment.
Actually %w can and should be used for errors in format.
https://stackoverflow.com/questions/61283248/format-errors-in-go-s-v-or-w
reachjainrahul
force-pushed
the
rulelevel
branch
2 times, most recently
from
6dc08d9 to
1e62ea1
Compare
|
/nephe-test-e2e-kind, /nephe-test-e2e-aks, /nephe-test-e2e-eks |
|
/nephe-test-e2e-aks |
Added one integration test for rule level appliedToGroup. Signed-off-by: Rahul Jain <[email protected]>
|
/nephe-test-e2e-kind, /nephe-test-e2e-aks, /nephe-test-e2e-eks |
shenmo3
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we can now support both RuleLevel AppliedTo and PolicyLevel AppliedTo configuration in Antrea NetworkPolicy.