Add webhook validations secret object #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yet to add the kubebuilder verbs to auto-generate the RBAC for webhook. |
Anandkumar26
force-pushed
the
webhook
branch
3 times, most recently
from
a00a8ca to
d42e3ea
Compare
Anandkumar26
changed the title
Anandkumar26
force-pushed
the
webhook
branch
from
d42e3ea to
4f8f4f9
Compare
Anandkumar26
force-pushed
the
webhook
branch
3 times, most recently
from
47cb929 to
d2e4b44
Compare
|
/nephe-test-e2e-kind |
Anandkumar26
force-pushed
the
webhook
branch
from
d2e4b44 to
7d87d39
Compare
|
The nephe-test-e2e-aws and nephe-test-e2e-azure has passed. Changed function descriptions for few functions, and updated comment in the test file. |
reachjainrahul
approved these changes
Sep 9, 2022
- Update of secrets are allowed only when the secret key (which is reffered by CPA) is not changed. - Delete of secrets are allowed only when it is not being referred by CPA. Signed-off-by: Anand Kumar <[email protected]>
- Coverage at 95.1% Signed-off-by: Anand Kumar <[email protected]>
reachjainrahul
force-pushed
the
webhook
branch
from
7d87d39 to
1d3ab88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(which is reffered by CPA) is not changed.
referred by CPA.
Signed-off-by: Anand Kumar [email protected]