Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vpc object in store on change in content and improve logging. #157

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

archanapholla
Copy link
Contributor

No description provided.

Copy link
Contributor

@Anandkumar26 Anandkumar26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archanapholla archanapholla force-pushed the vpc_update branch 2 times, most recently from ac5213c to 96e954f Compare March 15, 2023 18:01
@reachjainrahul
Copy link
Contributor

/nephe-test-e2e-kind

Copy link
Contributor

@reachjainrahul reachjainrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #157 (ebd8f6f) into main (e0e8671) will increase coverage by 0.04%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   55.56%   55.61%   +0.04%     
==========================================
  Files          52       52              
  Lines        8744     8756      +12     
==========================================
+ Hits         4859     4870      +11     
- Misses       3410     3412       +2     
+ Partials      475      474       -1     
Flag Coverage Δ
unit-tests 55.61% <65.21%> (+0.04%) ⬆️
Impacted Files Coverage Δ
pkg/controllers/inventory/inventory.go 63.49% <65.21%> (+0.74%) ⬆️

... and 1 file with indirect coverage changes

@reachjainrahul reachjainrahul merged commit 64862a0 into main Mar 19, 2023
@reachjainrahul reachjainrahul deleted the vpc_update branch June 2, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants