Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint option in cloudprovideraccount CRD #116

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

reachjainrahul
Copy link
Contributor

Endpoint can be used to set non AWS default URL. Primarily used to set endpoint to mock AWS services like localstack

Signed-off-by: Rahul Jain [email protected]

Endpoint can be used to set non AWS default URL. Primarily
used to set endpoint to mock AWS services like localstack

Signed-off-by: Rahul Jain <[email protected]>
@reachjainrahul
Copy link
Contributor Author

/nephe-test-e2e-aws, /nephe-test-e2e-eks

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #116 (9607748) into main (5a0f5aa) will increase coverage by 0.04%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   57.88%   57.93%   +0.04%     
==========================================
  Files          49       49              
  Lines        8033     8039       +6     
==========================================
+ Hits         4650     4657       +7     
  Misses       2904     2904              
+ Partials      479      478       -1     
Flag Coverage Δ
unit-tests 57.93% <16.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cloud-provider/cloudapi/aws/aws_services.go 18.64% <0.00%> (-0.33%) ⬇️
...kg/cloud-provider/cloudapi/aws/aws_account_mgmt.go 33.33% <20.00%> (-1.15%) ⬇️
pkg/controllers/cloud/networkpolicy.go 67.41% <0.00%> (+0.53%) ⬆️

Copy link
Contributor

@Anandkumar26 Anandkumar26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@reachjainrahul reachjainrahul added this to the Nephe v0.4.0 release milestone Feb 8, 2023
@reachjainrahul reachjainrahul merged commit ca5c43e into main Feb 8, 2023
@reachjainrahul reachjainrahul deleted the endpoint branch February 8, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants