Bump up go and golangci-lint version #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyingd
commented
Aug 23, 2023
•
wenyingd
commented
- Bump up go version to v1.21
- Bump up golangci-lint version to v1.54.0
wenyingd
changed the title
wenyingd
force-pushed
the
bumpup_go_golangci
branch
from
82105bc
to
de6b6fa
Compare
wenyingd
changed the title
antoninbas
reviewed
Aug 23, 2023
Makefile
Outdated
| @@ -1,5 +1,5 @@ | |||
| GO ?= go | |||
| GOLANGCI_LINT_VERSION := v1.52.2 | |||
| GOLANGCI_LINT_VERSION := v1.54.0 | |||
There was a problem hiding this comment.
I observe that antrea is using 1.54.0, so I change to the same version.
There was a problem hiding this comment.
the only reason why it uses 1.54.0 is because it was the latest version when I created my PR... There's no reason not to pick up the latest patch release here
wenyingd
force-pushed
the
bumpup_go_golangci
branch
from
de6b6fa
to
6d66ac8
Compare
antoninbas
previously approved these changes
Aug 25, 2023
|
|
wenyingd
force-pushed
the
bumpup_go_golangci
branch
from
6d66ac8
to
0db831b
Compare
1. Bump up go version to v1.21 2. Bump up golangci-lint version to v1.54.2 Signed-off-by: wenyingd <[email protected]>
wenyingd
force-pushed
the
bumpup_go_golangci
branch
from
0db831b
to
6713103
Compare
Yes, updated. |
antoninbas
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.