Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for matching NetworkPolicy rule without port number #882

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Add support for matching NetworkPolicy rule without port number #882

merged 1 commit into from
Jun 30, 2020

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Jun 29, 2020 •
edited
Loading

Match the protocol type as one conjunctive match flow if the port number in the
NetworkPolicy rule is not specified.

Fixes #877

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

@wenyingd
Copy link
Contributor Author

/test-all

@wenyingd wenyingd force-pushed the issue_877 branch 2 times, most recently from a9ccfb8 to 6a28113 Compare June 29, 2020 12:27
@wenyingd wenyingd requested a review from tnqn June 29, 2020 12:46
@wenyingd
Copy link
Contributor Author

/test-all

tnqn
tnqn reviewed Jun 29, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit

test/integration/agent/openflow_test.go Outdated Show resolved Hide resolved
@wenyingd
Add support for matching NetworkPolicy rule without port number
9f845c8 
Match the protocol type as one conjunctive match flow if the port number in the
NetworkPolicy rule is not specified.
@wenyingd wenyingd requested a review from abhiraut June 29, 2020 13:11
@wenyingd
Copy link
Contributor Author

/test-all

abhiraut
abhiraut approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@abhiraut abhiraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@wenyingd wenyingd merged commit 26b3285 into antrea-io:master Jun 30, 2020
@wenyingd wenyingd deleted the issue_877 branch June 30, 2020 01:00
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@wenyingd @GraysonWu
Add support for matching NetworkPolicy rule without port number (antr…
d3bc16e 
…ea-io#882)

Match the protocol type as one conjunctive match flow if the port number in the
NetworkPolicy rule is not specified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiraut abhiraut abhiraut approved these changes

@tnqn tnqn tnqn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkPolicy rule with Protocol specified but no Port leads to a runtime error
5 participants
@wenyingd @antrea-bot @abhiraut @tnqn @vmwclabot