Add retries for cni conf file #864
Conversation
|
@reachjainrahul, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. |
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
There was a problem hiding this comment.
In PR description, please use Fixes #xx to refer issue so that it can be closed automatically.
https://help.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords#closing-an-issue-in-the-same-repository
| if [[ ! -z $cni_conf ]]; then | ||
| break | ||
| fi | ||
| sleep 2s |
There was a problem hiding this comment.
Could we add some logging? otherwise it would be confusing the initContainer keeps running without any message if the cni conf is not available for a long time.
You may source logging and use log_info like https://github.com/vmware-tanzu/antrea/blob/master/build/images/scripts/start_ovs#L14
In CNI chain option, add retry to look for primary cni config file before adding antrea config in it
reachjainrahul
force-pushed
the
antrea-eks
branch
from
183a6c5 to
78853a0
Compare
There was a problem hiding this comment.
LGTM, thanks @reachjainrahul.
The current CI tests don't cover the change made in this PR so I would skip them.
@reachjainrahul Please let me know once you have verified it manually then we can merge.
|
/skip-all |
In CNI chain option, add retry to look for primary cni config file before adding antrea config in it
In CNI chain option, add retry to look for primary
cni config file before adding antrea config in it
Fixes #863