fix CmdCheck to failed on error #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
antoninbas
reviewed
Jun 10, 2020
| @@ -317,7 +317,7 @@ func (s *CNIServer) parsePrevResultFromRequest(networkConfig *NetworkConfig) (*c | |||
| return prevResult, nil | |||
| } | |||
|
|
|||
| func (s *CNIServer) validatePrevResult(cfgArgs *cnipb.CniCmdArgs, k8sCNIArgs *k8sArgs, prevResult *current.Result) (*cnipb.CniCmdResponse, error) { | |||
| func (s *CNIServer) validatePrevResult(cfgArgs *cnipb.CniCmdArgs, k8sCNIArgs *k8sArgs, prevResult *current.Result) *cnipb.CniCmdResponse { | |||
There was a problem hiding this comment.
maybe add a function comment to explain that the return value is nil if prevResult is valid
antoninbas
reviewed
Jun 10, 2020
pkg/agent/cniserver/server.go
Outdated
| @@ -317,7 +317,9 @@ func (s *CNIServer) parsePrevResultFromRequest(networkConfig *NetworkConfig) (*c | |||
| return prevResult, nil | |||
| } | |||
|
|
|||
| func (s *CNIServer) validatePrevResult(cfgArgs *cnipb.CniCmdArgs, k8sCNIArgs *k8sArgs, prevResult *current.Result) (*cnipb.CniCmdResponse, error) { | |||
| // validatePrevResult validate container and host interfaces configuration | |||
There was a problem hiding this comment.
s/validatePrevResult validate/validatePrevResult validates
CmdCheck will always returns success even if validation failed. This PS fixes it to return error as well.
|
/test-all |
|
/test-windows-conformance |
1 similar comment
|
/test-windows-conformance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CmdCheck will always returns success even if validation failed.
This PS fixes it to return error as well.