-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add healthz path to AlwaysAllowPaths #816
Conversation
The "/healthz" API is supposed to be accessed anonymously. However, there were unintentional subjectaccessreviews queries sent to the Kubernetes API when kubelets were executing liveness probe for antrea components. This patch adds "/healthz" path to AlwaysAllowPaths to avoid unnecessary overheads to the Kubernetes API.
/test-all |
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is it just an optimization or was it creating issues with probes for some clusters?
@antoninbas it didn't create issues, I observed failed subjectaccessreview requests every 10 seconds when debugging #802 (comment) with Jay (cannot access K8s svc after toggling security group is another issue I haven't root caused yet and may need a EC2 cluster to reproduce) and realized it would lead to 100 requests per second to K8s API in a scale cluster with 1000 nodes. |
@tnqn thanks for the clarification |
The "/healthz" API is supposed to be accessed anonymously. However, there were unintentional subjectaccessreviews queries sent to the Kubernetes API when kubelets were executing liveness probe for antrea components. This patch adds "/healthz" path to AlwaysAllowPaths to avoid unnecessary overheads to the Kubernetes API.
The "/healthz" API is supposed to be accessed anonymously. However, there were unintentional subjectaccessreviews queries sent to the Kubernetes API when kubelets were executing liveness probe for antrea components. This patch adds "/healthz" path to AlwaysAllowPaths to avoid unnecessary overheads to the Kubernetes API.
The "/healthz" API is supposed to be accessed anonymously. However, there were unintentional subjectaccessreviews queries sent to the Kubernetes API when kubelets were executing liveness probe for antrea components. This patch adds "/healthz" path to AlwaysAllowPaths to avoid unnecessary overheads to the Kubernetes API.
The "/healthz" API is supposed to be accessed anonymously. However, there were unintentional subjectaccessreviews queries sent to the Kubernetes API when kubelets were executing liveness probe for antrea components. This patch adds "/healthz" path to AlwaysAllowPaths to avoid unnecessary overheads to the Kubernetes API.
The "/healthz" API is supposed to be accessed anonymously. However,
there were unintentional subjectaccessreviews queries sent to the
Kubernetes API when kubelets were executing liveness probe for antrea
components. This patch adds "/healthz" path to AlwaysAllowPaths to avoid
unnecessary overheads to the Kubernetes API.