Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default reject rule to correctly handle packets that should be assembled #6857

Closed
wants to merge 1 commit into from
Closed

Fix default reject rule to correctly handle packets that should be assembled #6857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/agent/controller/networkpolicy/l7engine/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,10 @@ func generateTenantRulesData(policyName string, protoKeywords map[string]sets.Se
rulesData := bytes.NewBuffer(nil)
sid := 1

// Generate default reject rule.
allKeywords := fmt.Sprintf(`msg: "Reject by %s"; flow: to_server, established; sid: %d;`, policyName, sid)
// Generate default reject rule. The keyword `only_stream` is used to match on packets that have been reassembled by
// the Suricata stream engine. Without this keyword, reassembled packets, such as those from HTTP requests split
// across multiple packets, would be rejected by the default rule, causing an otherwise allowed connection to fail.
allKeywords := fmt.Sprintf(`msg: "Reject by %s"; flow: to_server, established, only_stream; sid: %d;`, policyName, sid)
rule := fmt.Sprintf("reject ip any any -> any any (%s)\n", allKeywords)
rulesData.WriteString(rule)
sid++
Expand Down
Loading