Allow Node SNAT for Static Egress case #6831
Conversation
rajnkamr
added
the
area/transit/egress
jainpulkit22
force-pushed
the
egress-record-update
branch
11 times, most recently
from
658ceb3 to
8dd6cfb
Compare
jainpulkit22
force-pushed
the
egress-record-update
branch
2 times, most recently
from
be099f9 to
1f5c419
Compare
jainpulkit22
force-pushed
the
egress-record-update
branch
2 times, most recently
from
62ff87c to
c0bc9dd
Compare
| eState.pods.Insert(pod) | ||
| stalePods.Delete(pod) | ||
| egress, _ = c.egressLister.Get(egressName) | ||
| if egress.Status.EgressNode != "" { |
There was a problem hiding this comment.
As I pointed out before, I do feel like it is strange to consume .Status.EgressNode as part of the controller, and I am not sure this feature is very useful, but I will let @tnqn review & decide.
There was a problem hiding this comment.
I'm not sure if this is an improvement either. Note that if this behavior change isn't wanted by all users, it would satisfy some while breaking others. The issue being addressed doesn't come from end users so I would prefer keeping it as was.
Instead of changing the behavior from one to another, I would prefer making it explicit and configurable, letting user know and decide what would happen.
There was a problem hiding this comment.
okay so in that case we can have a config variable set by user in antrea.yml and if that i set then we can allow normal Node SNAT if static egress is not assigned to any node, and if the variable is not set or is false then we will keep the behaviour as it is.
Is it what is expected @antoninbas @tnqn
jainpulkit22
force-pushed
the
egress-record-update
branch
3 times, most recently
from
7267a38 to
592fec7
Compare
Implemented best effort scenario, where in case of static Egress also, if there is no egress node then the packets will be sent using normal Node SNAT, as in case of dynamic Egress. Signed-off-by: Pulkit Jain <[email protected]>
jainpulkit22
force-pushed
the
egress-record-update
branch
from
592fec7 to
afe7285
Compare
Implemented best effort scenario, where in case of static Egress also, if there is no egress node then the packets will be sent using normal Node SNAT, as in case of dynamic Egress.
For #6228.