Remove incorrect AntreaProxy warning on Windows #6242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was logging an incorrect warning about AntreaProxy being disabled. This is is because checkUnsupportedFeatures was in charge of the check, but o.enableAntreaProxy is set later in the validation chain. To avoid the issue, we introduce a new function for platform-specific checks, validateConfigForPlatform, which runs after all other validations and after all fields in the Options struct have been set. We also replace the warning message with an error message (but we do not fail Agent initialization) and we add a check for proxyAll. Signed-off-by: Antonin Bas <[email protected]>
|
/skip-all |
antoninbas
added
the
action/release-note
|
It's pretty minor, so I don't think I will backport this. It doesn't impact functionality. |
antoninbas
added
area/OS/windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was logging an incorrect warning about AntreaProxy being disabled. This is is because checkUnsupportedFeatures was in charge of the check, but o.enableAntreaProxy is set later in the validation chain. To avoid the issue, we introduce a new function for platform-specific checks, validateConfigForPlatform, which runs after all other validations and after all fields in the Options struct have been set.
We also replace the warning message with an error message (but we do not fail Agent initialization) and we add a check for proxyAll.