Add checksum of windows config files as annotations #5545
Conversation
Atish-iaf
added
the
area/OS/windows
Thanks for the suggestion, I can try to do this after #5440 as it will bring some changes in manifest, so i think we can wait for it. |
hack/update-checksum-windows.sh
Outdated
| WINDOWS_DIR="${YAMLS_DIR}"/windows | ||
| WINDOWS_YAMLS="${YAMLS_DIR}/antrea-windows.yml ${YAMLS_DIR}/antrea-windows-containerd.yml ${YAMLS_DIR}/antrea-windows-containerd-with-ovs.yml" | ||
|
|
||
| checksum_windows_config=$(cat ${WINDOWS_DIR}/base/conf/antrea-agent.conf ${WINDOWS_DIR}/base/conf/antrea-cni.conflist | sha256sum | cut -d " " -f 1) |
There was a problem hiding this comment.
can check if files exists before calculating checksum, some files might get removed/renamed etc in future, similar for others for error handling etc
if [ -f "${WINDOWS_DIR}/base/conf/antrea-agent.conf" ] && [ -f "${WINDOWS_DIR}/base/conf/antrea-cni.conflist" ]; then
There was a problem hiding this comment.
the script should definitely fail if a file is missing though, it should not silently ignore the missing file
Atish-iaf
force-pushed
the
windows-checksum-config
branch
from
d1616e6 to
4037f8d
Compare
#5564 is created to explore using helm for generating windows manifests after completion of #5440 |
Atish-iaf
force-pushed
the
windows-checksum-config
branch
from
4037f8d to
bd75f1d
Compare
When the ConfigMap is generated with suffix by kustomize, it will generate a manifest with new ConfigMap like 'antrea-windows-config-***'. When a new manifest is applied, it will leave stale ConfigMaps. To avoid stale ConfigMaps, here we add checksum of windows configuration files as annotations. Signed-off-by: Kumar Atish <[email protected]>
Atish-iaf
force-pushed
the
windows-checksum-config
branch
from
bd75f1d to
9dc879c
Compare
|
/test-windows-all |
|
/test-windows-all |
|
/test-windows-e2e |
|
/test-windows-containerd-e2e |
|
/test-windows-containerd-e2e |
|
/test-windows-containerd-conformance |
|
@antoninbas could you please help to merge this PR ? Thanks. |
antoninbas
added
the
action/release-note
When the ConfigMap is generated with suffix by kustomize, it will generate a manifest with new ConfigMap like 'antrea-windows-config-***'. When a new manifest is applied, it will leave stale ConfigMaps. To avoid stale ConfigMaps, here we add checksum of windows configuration files as annotations.