Add a ClusterSet deletion webhook for the leader cluster #5475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
force-pushed
the
mc-leader-deletion-webhook
branch
5 times, most recently
from
f6ad0c3 to
20a4ad7
Compare
|
/test-multicluster-e2e |
|
In commit message MemberClusterResource -> MemberClusterAnnounce |
jianjuns
changed the title
jianjuns
reviewed
Sep 13, 2023
| @@ -63,6 +63,13 @@ func runMember(o *Options) error { | |||
| Client: mgr.GetClient(), | |||
| namespace: env.GetPodNamespace()}}) | |||
|
|
|||
| hookServer.Register("/validate-multicluster-crd-antrea-io-v1alpha2-clusterset", | |||
There was a problem hiding this comment.
Question - we also need to register the handler for a member cluster?
There was a problem hiding this comment.
Yes, this ClusterSet webhook was registered in controller.go before because there is no difference for the creation/update validation webhook in both leader and member clusters. But now, the deletion webhook is only required for the leader, so I moved this to the leader.go and member.go to get the role info. For the member cluster, it's no-ops for deletion event.
Add a ClusterSet deletion webhook to fail the ClusterSet deletion request in the leader cluster when any MemberClusterAnnounce exists. Signed-off-by: Lan Luo <[email protected]>
luolanzone
force-pushed
the
mc-leader-deletion-webhook
branch
from
20a4ad7 to
74aebe8
Compare
|
/test-multicluster-e2e |
jianjuns
approved these changes
Sep 15, 2023
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a ClusterSet deletion webhook to fail the ClusterSet deletion request
in the leader cluster when any MemberClusterAnnounce exists.