Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to v1.21 #5377

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Update Go to v1.21 #5377

merged 6 commits into from
Aug 22, 2023

Conversation

antoninbas
Copy link
Contributor

  • Replace usage of "golang.org/x/exp/slices" with new "slices" package.
  • Remove calls to "rand.Seed": starting with Go v1.20, the generator is seeded randomly at program startup, and we no longer need to do it manually.
  • The codegen image has been updated to kubernetes-1.26.4-build.0 to include the updated version of Go. No changes im generated files.
  • Stop using "golang.org/x/exp/rand" in test/e2e/performance_test.go: this is unrelated to the Go update.

Fixes #5371

@antoninbas antoninbas requested review from tnqn and luolanzone August 9, 2023 23:08
@luolanzone
Copy link
Contributor

There is a typo in the PR message: No changes im generated files. -> No changes in generated files.
A few github actions check failed.

@luolanzone luolanzone added the action/release-note Indicates a PR that should be included in release notes. label Aug 10, 2023
tnqn
tnqn previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/test-all
/test-windows-all

1 similar comment
@antoninbas
Copy link
Contributor Author

/test-all
/test-windows-all

@antoninbas
Copy link
Contributor Author

/test-e2e
/test-windows-e2e

@antoninbas
Copy link
Contributor Author

/test-e2e
/test-windows-conformance

tnqn
tnqn previously approved these changes Aug 16, 2023
View reviewed changes
@antoninbas
Copy link
Contributor Author

/test-e2e
/test-multicluster-e2e
/test-ipv6-e2e
/test-ipv6-only-e2e

@antoninbas
Copy link
Contributor Author

/test-multicluster-e2e
/test-ipv6-e2e
/test-ipv6-only-e2e

@antoninbas
Copy link
Contributor Author

/test-ipv6-e2e
/test-ipv6-only-e2e

@antoninbas
Copy link
Contributor Author

/test-multicluster-e2e

@antoninbas antoninbas force-pushed the update-golang-to-v1.21 branch from 550bc92 to 4899bd4 Compare August 21, 2023 17:52
@antoninbas
Copy link
Contributor Author

/test-multicluster-e2e
/test-ipv6-e2e
/test-ipv6-only-e2e

@antoninbas
Copy link
Contributor Author

/test-multicluster-e2e
/test-ipv6-only-e2e

@antoninbas
Copy link
Contributor Author

/test-multicluster-e2e

5 similar comments
@luolanzone
Copy link
Contributor

/test-multicluster-e2e

@luolanzone
Copy link
Contributor

/test-multicluster-e2e

@luolanzone
Copy link
Contributor

/test-multicluster-e2e

@luolanzone
Copy link
Contributor

/test-multicluster-e2e

@luolanzone
Copy link
Contributor

/test-multicluster-e2e

@antoninbas
Update Go to v1.21
61aad6f 
* Replace usage of "golang.org/x/exp/slices" with new "slices" package.
* Remove calls to "rand.Seed": starting with Go v1.20, the generator is seeded
  randomly at program startup, and we no longer need to do it manually.
* The codegen image has been updated to kubernetes-1.26.4-build.0 to
  include the updated version of Go. No changes im generated files.
* Stop using "golang.org/x/exp/rand" in test/e2e/performance_test.go: this is
  unrelated to the Go update.

Fixes antrea-io#5371

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas
Use windows-2022 runners for Go Windows unit tests
e8e86f3 
After upgrading to Go v1.21, Go Windows unit tests (which we run with
the race detector enabled) cannot be run: go exists immediately with
`exit status 0xc0000139`.

That may be caused by older mingw-w64 runtime libraries. See
golang/go#61058.

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas
Fix Dockerfile for integrations tests image
db961bd 
The Dockerfile should install the latest patch release for the minor Go
version currently supported by Antrea.

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas
Fix Antctl e2e test cases
e2f5045 
Signed-off-by: Antonin Bas <[email protected]>
@antoninbas
Update metrics doc
da69cb7 
Additional metrics are available with Go v1.21.

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas
Increase timeout in e2e test
231f509 
Signed-off-by: Antonin Bas <[email protected]>
@antoninbas antoninbas force-pushed the update-golang-to-v1.21 branch from 4899bd4 to 231f509 Compare August 22, 2023 05:41
@antoninbas
Copy link
Contributor Author

/test-all
/test-multicluster-e2e
/test-ipv6-e2e
/test-ipv6-only-e2e

@antoninbas
Copy link
Contributor Author

/test-windows-all

@antoninbas
Copy link
Contributor Author

/test-ipv6-e2e
/test-ipv6-only-e2e

@antoninbas antoninbas merged commit 629cd0b into antrea-io:main Aug 22, 2023
@antoninbas antoninbas deleted the update-golang-to-v1.21 branch August 22, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luolanzone luolanzone luolanzone approved these changes

@tnqn tnqn tnqn left review comments

Assignees
No one assigned
Labels
action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Go to 1.21
3 participants
@antoninbas @luolanzone @tnqn