Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing protocol in service when processing ANP named ports #5370

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

Dyanngg
Copy link
Contributor

@Dyanngg Dyanngg commented Aug 8, 2023

When processing AdminNetworkPolicy and BaselineAdminNetworkPolicy named port rules, the ports section will not have protocol specified. Antrea agent should infer the protocol from the container spec so that rule can be enforced correctly in ovs.
Change has been verified with kubernetes-sigs/network-policy-api#132

When processing AdminNetworkPolicy and BaselineAdminNetworkPolicy
named port rules, the ports section will not have protocol specified.
Antrea agent should infer the protocol from the container spec so
that rule can be enforced correctly in ovs.

Signed-off-by: Dyanngg <[email protected]>
@Dyanngg Dyanngg requested review from tnqn and GraysonWu August 8, 2023 18:21
@Dyanngg Dyanngg changed the title Fix misisng protocol in service when processing ANP named ports Fix missing protocol in service when processing ANP named ports Aug 8, 2023
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn added action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. labels Aug 15, 2023
@tnqn
Copy link
Member

tnqn commented Aug 15, 2023

/skip-all

@tnqn
Copy link
Member

tnqn commented Aug 15, 2023

@Dyanngg could you backport it to release-1.13 as well?

@tnqn tnqn merged commit a84aea9 into antrea-io:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants