Add log rotation configuration for VM Agent #5366
Conversation
mengdie-song
force-pushed
the
vm-fixpanic
branch
from
ca6b94b to
4ccb74b
Compare
|
Hi @antoninbas , I just found VM Agent crashed on main branch because the newly added log rotation configurations are nil. |
There was a problem hiding this comment.
Thanks @mengdie-song. I'll merge this PR as is.
However, the real issue is that I mistakenly added the code responsible for initializing the auditLogging configuration to setK8sNodeDefaultOptions instead of setDefaults in cmd/antrea-agent/options.go.
|
/test-vm-e2e |
|
Follow-up PR to fix initialization in options.go: #5369 |
|
/test-vm-e2e |
|
@mengdie-song could you rebase the PR and run |
VM Agent crashes because log rotation configuration is nil. This change adds log rotation configuration for VM Agent. Signed-off-by: Mengdie Song <[email protected]>
mengdie-song
force-pushed
the
vm-fixpanic
branch
from
4ccb74b to
30954a5
Compare
|
/test-vm-e2e |
|
Hi @antoninbas, I has rebased the PR and VM e2e test has passed. Regarding the e2e cleanup issue, I have another change to fix it (#5406). |
|
/skip-conformance |
VM Agent crashes because log rotation configuration is nil.
This change adds log rotation configuration for VM Agent.