Improve antctl get featuregates output #5314

cr7258 · 2023-07-25T05:04:18Z

Here are the major changes in this PR:

1.Keep the information about which component is using the FeatureGate in antrea_features.go.
2.For controller and remote mode, get feature gates by reading ConfigMap and include antrea-agent-windows feature gates for improvement.

Test

remote mode (outside of the cluster) / In antrea-controller Pod:

root@kind-demo:~# antctl get featuregates
Antrea Agent Feature Gates
FEATUREGATE                     STATUS       VERSION
AntreaIPAM                      Disabled     ALPHA
AntreaPolicy                    Enabled      BETA
AntreaProxy                     Enabled      BETA
CleanupStaleUDPSvcConntrack     Disabled     ALPHA
Egress                          Enabled      BETA
EndpointSlice                   Enabled      BETA
ExternalNode                    Disabled     ALPHA
FlowExporter                    Disabled     ALPHA
IPsecCertAuth                   Disabled     ALPHA
L7NetworkPolicy                 Disabled     ALPHA
LoadBalancerModeDSR             Disabled     ALPHA
Multicast                       Enabled      BETA
Multicluster                    Disabled     ALPHA
NetworkPolicyStats              Enabled      BETA
NodePortLocal                   Enabled      BETA
SecondaryNetwork                Disabled     ALPHA
ServiceExternalIP               Disabled     ALPHA
SupportBundleCollection         Disabled     ALPHA
TopologyAwareHints              Enabled      BETA
Traceflow                       Enabled      BETA
TrafficControl                  Disabled     ALPHA

Antrea Controller Feature Gates
FEATUREGATE                 STATUS       VERSION
AdminNetworkPolicy          Disabled     ALPHA
AntreaIPAM                  Disabled     ALPHA
AntreaPolicy                Enabled      BETA
Egress                      Enabled      BETA
IPsecCertAuth               Disabled     ALPHA
L7NetworkPolicy             Disabled     ALPHA
Multicast                   Enabled      BETA
Multicluster                Disabled     ALPHA
NetworkPolicyStats          Enabled      BETA
NodeIPAM                    Enabled      BETA
ServiceExternalIP           Disabled     ALPHA
SupportBundleCollection     Disabled     ALPHA
Traceflow                   Enabled      BETA

in antrea-agent Pod:

Antrea Agent Feature Gates
FEATUREGATE                     STATUS       VERSION
AntreaIPAM                      Disabled     ALPHA
AntreaPolicy                    Enabled      BETA
AntreaProxy                     Enabled      BETA
CleanupStaleUDPSvcConntrack     Disabled     ALPHA
Egress                          Enabled      BETA
EndpointSlice                   Enabled      BETA
ExternalNode                    Disabled     ALPHA
FlowExporter                    Disabled     ALPHA
IPsecCertAuth                   Disabled     ALPHA
L7NetworkPolicy                 Disabled     ALPHA
LoadBalancerModeDSR             Disabled     ALPHA
Multicast                       Enabled      BETA
Multicluster                    Disabled     ALPHA
NetworkPolicyStats              Enabled      BETA
NodePortLocal                   Enabled      BETA
SecondaryNetwork                Disabled     ALPHA
ServiceExternalIP               Disabled     ALPHA
SupportBundleCollection         Disabled     ALPHA
TopologyAwareHints              Enabled      BETA
Traceflow                       Enabled      BETA
TrafficControl                  Disabled     ALPHA

remote mode (outside of the cluster) / In antrea-controller Pod with antrea-windows-config-xxx Configmap:

root@kind-demo:~# kubectl exec -it -n kube-system antrea-controller-54f97f54c4-8wj7m -- antctl get featuregates
Antrea Agent Feature Gates
FEATUREGATE                     STATUS       VERSION
AntreaIPAM                      Disabled     ALPHA
AntreaPolicy                    Enabled      BETA
AntreaProxy                     Enabled      BETA
CleanupStaleUDPSvcConntrack     Disabled     ALPHA
Egress                          Enabled      BETA
EndpointSlice                   Enabled      BETA
ExternalNode                    Disabled     ALPHA
FlowExporter                    Disabled     ALPHA
IPsecCertAuth                   Disabled     ALPHA
L7NetworkPolicy                 Disabled     ALPHA
LoadBalancerModeDSR             Disabled     ALPHA
Multicast                       Enabled      BETA
Multicluster                    Disabled     ALPHA
NetworkPolicyStats              Enabled      BETA
NodePortLocal                   Enabled      BETA
SecondaryNetwork                Disabled     ALPHA
ServiceExternalIP               Disabled     ALPHA
SupportBundleCollection         Disabled     ALPHA
TopologyAwareHints              Enabled      BETA
Traceflow                       Enabled      BETA
TrafficControl                  Disabled     ALPHA

Antrea Agent Feature Gates (Windows)
FEATUREGATE                 STATUS       VERSION
AntreaPolicy                Enabled      BETA
AntreaProxy                 Enabled      BETA
EndpointSlice               Enabled      BETA
ExternalNode                Disabled     ALPHA
FlowExporter                Disabled     ALPHA
NetworkPolicyStats          Enabled      BETA
NodePortLocal               Enabled      BETA
SupportBundleCollection     Disabled     ALPHA
TopologyAwareHints          Enabled      BETA
Traceflow                   Enabled      BETA
TrafficControl              Disabled     ALPHA

Antrea Controller Feature Gates
FEATUREGATE                 STATUS       VERSION
AdminNetworkPolicy          Disabled     ALPHA
AntreaIPAM                  Disabled     ALPHA
AntreaPolicy                Enabled      BETA
Egress                      Enabled      BETA
IPsecCertAuth               Disabled     ALPHA
L7NetworkPolicy             Disabled     ALPHA
Multicast                   Enabled      BETA
Multicluster                Disabled     ALPHA
NetworkPolicyStats          Enabled      BETA
NodeIPAM                    Enabled      BETA
ServiceExternalIP           Disabled     ALPHA
SupportBundleCollection     Disabled     ALPHA
Traceflow                   Enabled      BETA

docs/feature-gates.md

pkg/antctl/raw/featuregates/command.go

pkg/apiserver/handlers/featuregates/handler.go

pkg/apiserver/handlers/featuregates/handler_test.go

pkg/features/antrea_features.go

pkg/antctl/raw/featuregates/command_test.go

docs/feature-gates.md

pkg/features/antrea_features.go

luolanzone · 2023-07-31T03:07:00Z

Please help to resolve the doc conflicts. We had a new feature gate AdminNetworkPolicy since v1.13, you need also update the feature gate list for this new feature. Don't forget to update the antctl doc since the print behavior is different now.

cr7258 · 2023-07-31T08:34:23Z

Please help to resolve the doc conflicts. We had a new feature gate AdminNetworkPolicy since v1.13, you need also update the feature gate list for this new feature. Don't forget to update the antctl doc since the print behavior is different now.

update the feature gate list: 5f1a4a7
update the antctl doc: 2566f74

cr7258 · 2023-07-31T08:35:51Z

Hi @hongliangl @luolanzone, I have addressed all comments, please review them again, Thanks.

hongliangl

You need to rebase this PR.

Tips: when rebasing this PR

Just accept all yaml files from the latest main branch
Run make manifest to update all yaml files.

pkg/apiserver/handlers/featuregates/handler.go

docs/antctl.md

pkg/features/antrea_features.go

luolanzone · 2023-08-02T02:09:17Z

@cr7258, there are too many commits in this PR, please help to squash them. The DCO check is also failed, you need to add sign-off-by info in each commit. You can take a look at other PRs to learn how to add DCO info.

cr7258 · 2023-08-02T02:13:07Z

You need to rebase this PR.

Tips: when rebasing this PR

Just accept all yaml files from the latest main branch

Run make manifest to update all yaml files.

Done

hongliangl · 2023-08-02T02:20:40Z

You don't need to push a comment for every review comment. You could just amend the updates, or commit the updates and squash the commits into one commit. Then you push the new commit with parameter --force to overwrite the remote repo.

cr7258 · 2023-08-02T02:27:36Z

I squashed all commits.

tnqn · 2023-08-24T06:54:11Z

The use of keyword "fix" in the PR description of #5433 automatically closed the PR on behalf of me. Please avoid using closing keywords to link issues/PRs in the future if merging a PR shouldn't close the other one.

pkg/agent/apiserver/handlers/featuregates/handler_test.go

pkg/antctl/raw/featuregates/command.go

pkg/antctl/runtime/runtime.go

pkg/apiserver/handlers/featuregates/handler.go

Signed-off-by: chengzw <[email protected]>

antoninbas

a couple more small comments, otherwise LGTM

make sure you get another review

pkg/agent/apiserver/handlers/featuregates/handler_test.go

pkg/antctl/raw/featuregates/command.go

pkg/apiserver/handlers/featuregates/handler.go

pkg/apiserver/handlers/featuregates/handler_test.go

Signed-off-by: chengzw <[email protected]>

cr7258 · 2023-08-31T01:48:32Z

Hi @antoninbas, I adjusted the code according to your comments, please review them again, thanks.

tnqn

LGTM, but would defer to Antonin for final approval as he has been reviewing it since the begining.
@cr7258 Antonin is on vacation and will be back next week.

antoninbas · 2023-09-18T22:43:23Z

/test-all

antoninbas · 2023-09-18T22:44:14Z

/test-windows-e2e

antoninbas · 2023-09-19T18:48:11Z

/test-e2e

antoninbas · 2023-09-20T01:37:16Z

/test-windows-containerd-e2e

antoninbas · 2023-09-20T17:08:02Z

I resolved a small conflict in the Github UI. No need to run Jenkins tests again. Will merge once Go and Kind tests have passed.

Signed-off-by: Antonin Bas <[email protected]>

antoninbas · 2023-09-20T21:24:08Z

/skip-all

cr7258 changed the title ~~Improve antctl get featuregates~~ Improve antctl get featuregates output Jul 25, 2023

cr7258 force-pushed the improve-antctl-get-featuregates branch 6 times, most recently from 9848098 to 00b9070 Compare July 25, 2023 13:18

hongliangl reviewed Jul 28, 2023

View reviewed changes

hongliangl added the area/component/antctl Issues or PRs releated to the command line interface component label Jul 28, 2023

hongliangl reviewed Jul 28, 2023

View reviewed changes

pkg/antctl/raw/featuregates/command_test.go Outdated Show resolved Hide resolved

luolanzone reviewed Jul 31, 2023

View reviewed changes

docs/feature-gates.md Outdated Show resolved Hide resolved

pkg/features/antrea_features.go Outdated Show resolved Hide resolved

cr7258 force-pushed the improve-antctl-get-featuregates branch 6 times, most recently from ed8b4a2 to 8edb199 Compare July 31, 2023 06:12

cr7258 requested review from hongliangl and luolanzone July 31, 2023 08:35

hongliangl reviewed Aug 2, 2023

View reviewed changes

pkg/apiserver/handlers/featuregates/handler.go Outdated Show resolved Hide resolved

docs/antctl.md Outdated Show resolved Hide resolved

pkg/features/antrea_features.go Outdated Show resolved Hide resolved

pkg/features/antrea_features.go Outdated Show resolved Hide resolved

cr7258 force-pushed the improve-antctl-get-featuregates branch 2 times, most recently from 66aaa82 to 9ca7370 Compare August 2, 2023 02:11

cr7258 force-pushed the improve-antctl-get-featuregates branch from 9ca7370 to 41cd9a7 Compare August 2, 2023 02:26

tnqn reopened this Aug 24, 2023

antoninbas reviewed Aug 24, 2023

View reviewed changes

adjust code according to suggestions

1a73d44

Signed-off-by: chengzw <[email protected]>

cr7258 requested a review from antoninbas August 25, 2023 01:40

antoninbas reviewed Aug 25, 2023

View reviewed changes

cr7258 force-pushed the improve-antctl-get-featuregates branch 2 times, most recently from 4a79646 to 94e819d Compare August 26, 2023 02:13

adjust code according to suggestions

3373af6

Signed-off-by: chengzw <[email protected]>

cr7258 force-pushed the improve-antctl-get-featuregates branch from 94e819d to 3373af6 Compare August 26, 2023 02:17

cr7258 requested a review from antoninbas August 26, 2023 02:17

tnqn previously approved these changes Sep 5, 2023

View reviewed changes

antoninbas previously approved these changes Sep 18, 2023

View reviewed changes

Merge branch 'main' into improve-antctl-get-featuregates

2a34e84

antoninbas dismissed stale reviews from tnqn and themself via 2a34e84 September 20, 2023 17:07

antoninbas previously approved these changes Sep 20, 2023

View reviewed changes

Fix unit test

cf4d8dc

Signed-off-by: Antonin Bas <[email protected]>

antoninbas dismissed their stale review via cf4d8dc September 20, 2023 17:51

antoninbas approved these changes Sep 20, 2023

View reviewed changes

antoninbas merged commit e16c364 into antrea-io:main Sep 20, 2023

antoninbas added the action/release-note Indicates a PR that should be included in release notes. label Sep 21, 2023

antoninbas added this to the Antrea v1.14 release milestone Sep 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve antctl get featuregates output #5314

Improve antctl get featuregates output #5314

cr7258 commented Jul 25, 2023 •

edited

Loading

luolanzone commented Jul 31, 2023

cr7258 commented Jul 31, 2023

cr7258 commented Jul 31, 2023

hongliangl left a comment

luolanzone commented Aug 2, 2023

cr7258 commented Aug 2, 2023

hongliangl commented Aug 2, 2023

cr7258 commented Aug 2, 2023 •

edited

Loading

tnqn commented Aug 24, 2023

antoninbas left a comment

cr7258 commented Aug 31, 2023

tnqn left a comment

antoninbas commented Sep 18, 2023

antoninbas commented Sep 18, 2023

antoninbas commented Sep 19, 2023

antoninbas commented Sep 20, 2023

antoninbas commented Sep 20, 2023

antoninbas commented Sep 20, 2023

Improve antctl get featuregates output #5314

Improve antctl get featuregates output #5314

Conversation

cr7258 commented Jul 25, 2023 • edited Loading

Test

luolanzone commented Jul 31, 2023

cr7258 commented Jul 31, 2023

cr7258 commented Jul 31, 2023

hongliangl left a comment

Choose a reason for hiding this comment

luolanzone commented Aug 2, 2023

cr7258 commented Aug 2, 2023

hongliangl commented Aug 2, 2023

cr7258 commented Aug 2, 2023 • edited Loading

tnqn commented Aug 24, 2023

antoninbas left a comment

Choose a reason for hiding this comment

cr7258 commented Aug 31, 2023

tnqn left a comment

Choose a reason for hiding this comment

antoninbas commented Sep 18, 2023

antoninbas commented Sep 18, 2023

antoninbas commented Sep 19, 2023

antoninbas commented Sep 20, 2023

antoninbas commented Sep 20, 2023

antoninbas commented Sep 20, 2023

cr7258 commented Jul 25, 2023 •

edited

Loading

cr7258 commented Aug 2, 2023 •

edited

Loading