Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4459: Upgrade Antrea base image to ubuntu:22.04 #4499: Update remaining images to use ubuntu:22.04 base image #4525

Conversation

xliuxu
Copy link
Contributor

@xliuxu xliuxu commented Jan 3, 2023

Cherry pick of #4459 #4499 on release-1.8.

#4459: Upgrade Antrea base image to ubuntu:22.04
#4499: Update remaining images to use ubuntu:22.04 base image

For details on the cherry pick process, see the cherry pick requests page.

@xliuxu xliuxu added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #4525 (cdaca95) into release-1.8 (45b2090) will increase coverage by 3.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.8    #4525      +/-   ##
===============================================
+ Coverage        63.16%   66.23%   +3.07%     
===============================================
  Files              304      304              
  Lines            46650    46650              
===============================================
+ Hits             29466    30899    +1433     
+ Misses           14829    13346    -1483     
- Partials          2355     2405      +50     
Flag Coverage Δ
e2e-tests 39.30% <ø> (?)
integration-tests 35.11% <ø> (+0.01%) ⬆️
kind-e2e-tests 48.31% <ø> (+6.02%) ⬆️
unit-tests 45.16% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
pkg/agent/flowexporter/utils.go 61.70% <0.00%> (-10.64%) ⬇️
pkg/apiserver/certificate/certificate.go 70.37% <0.00%> (-6.49%) ⬇️
pkg/agent/util/iptables/iptables.go 45.07% <0.00%> (-3.11%) ⬇️
pkg/controller/externalippool/controller.go 83.03% <0.00%> (-1.79%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 73.39% <0.00%> (+0.49%) ⬆️
pkg/ipam/ipallocator/allocator.go 88.14% <0.00%> (+0.51%) ⬆️
pkg/controller/ipam/validate.go 80.32% <0.00%> (+0.54%) ⬆️
pkg/agent/controller/traceflow/packetin.go 63.43% <0.00%> (+0.62%) ⬆️
pkg/agent/openflow/network_policy.go 79.36% <0.00%> (+0.86%) ⬆️
pkg/agent/controller/networkpolicy/fqdn.go 74.68% <0.00%> (+0.89%) ⬆️
... and 55 more

Ubuntu 20.04 comes with iptables 1.8.4, which seems to have several bugs
when used with nft. In particular, we observe that iptables-restore
sometimes segfaults when restoring the ANTREA-NODE-PORT-LOCAL chain in
the nat table. Ubuntu 22.04 comes with a more recent iptables version,
1.8.7.

As part of this change, we change the tag format for base images
(antrea/openvswitch and antrea/base-ubuntu). We no longer use the OVS
version as the tag, instead we use the Antrea minor version number.

Fixes antrea-io#4435

Signed-off-by: Antonin Bas <[email protected]>
@xliuxu xliuxu force-pushed the automated-cherry-pick-of-#4459-#4499-upstream-release-1.8 branch from cd63e84 to f858270 Compare January 3, 2023 02:39
@xliuxu
Copy link
Contributor Author

xliuxu commented Jan 3, 2023

/test-all

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hack/update-codegen.sh Outdated Show resolved Hide resolved
@xliuxu xliuxu force-pushed the automated-cherry-pick-of-#4459-#4499-upstream-release-1.8 branch 2 times, most recently from 342c0ab to 23820d9 Compare January 3, 2023 04:41
@tnqn
Copy link
Member

tnqn commented Jan 3, 2023

“Check tidy, code generation and manifest” still failed

We also update the Vagrant-based test infra to use Ubuntu 22.04 as the
Node OS. Because Ubuntu 22.04 ships with crgroup v2, we need to
configure containerd to use the systemd cgroup driver.

Signed-off-by: Antonin Bas <[email protected]>
@xliuxu xliuxu force-pushed the automated-cherry-pick-of-#4459-#4499-upstream-release-1.8 branch from 23820d9 to cdaca95 Compare January 4, 2023 06:32
@xliuxu
Copy link
Contributor Author

xliuxu commented Jan 4, 2023

/test-all

@xliuxu
Copy link
Contributor Author

xliuxu commented Jan 4, 2023

“Check tidy, code generation and manifest” still failed
I revered the change to the image of codegen as antrea 1.8 still uses go 1.7.

@tnqn tnqn merged commit efe8c1a into antrea-io:release-1.8 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants