Fix log spam when there is any DNS based LoadBalancer Service #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IP in Service.Status.LoadBalancer.Ingress is optional and may be not set for load-balancer ingress points that are DNS based. It should check if the IP is empty before appending it to the slice, otherwise every round of sync will produce one error log "Skipping invalid IP:" for each IP, leading to log spam. The same issue has been fixed in K8s upstream by kubernetes/kubernetes#101690. Signed-off-by: Quan Tian <[email protected]>
tnqn
added
action/backport
tnqn
commented
Sep 16, 2022
| @@ -286,8 +289,10 @@ func NewServiceChangeTracker(makeServiceInfo makeServicePortFunc, | |||
| // otherwise return false. Update can be used to add/update/delete items of ServiceChangeMap. For example, | |||
| // Add item | |||
| // - pass <nil, service> as the <previous, current> pair. | |||
| // | |||
There was a problem hiding this comment.
The following change is by gofmt, guess related to go1.19.
Codecov Report
@@ Coverage Diff @@
## main #4234 +/- ##
==========================================
+ Coverage 60.34% 64.55% +4.21%
==========================================
Files 385 361 -24
Lines 54456 52188 -2268
==========================================
+ Hits 32862 33691 +829
+ Misses 19130 16052 -3078
+ Partials 2464 2445 -19
*This pull request uses carry forward flags. Click here to find out more.
|
|
/test-all |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
…-io#4234) IP in Service.Status.LoadBalancer.Ingress is optional and may be not set for load-balancer ingress points that are DNS based. It should check if the IP is empty before appending it to the slice, otherwise every round of sync will produce one error log "Skipping invalid IP:" for each IP, leading to log spam. The same issue has been fixed in K8s upstream by kubernetes/kubernetes#101690. Signed-off-by: Quan Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IP in Service.Status.LoadBalancer.Ingress is optional and may be not set for load-balancer ingress points that are DNS based. It should check if the IP is empty before appending it to the slice, otherwise every round of sync will produce one error log "Skipping invalid IP:" for each IP, leading to log spam.
The same issue has been fixed in K8s upstream by
kubernetes/kubernetes#101690.
Signed-off-by: Quan Tian [email protected]
Fix #4233