Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3691: Reduce permission of antrea-agent service account #3749

Conversation

xliuxu
Copy link
Contributor

@xliuxu xliuxu commented May 7, 2022

Cherry pick of #3691 on release-1.5.

#3691: Reduce permission of antrea-agent service account

For details on the cherry pick process, see the cherry pick requests page.

@xliuxu xliuxu added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label May 7, 2022
@xliuxu xliuxu force-pushed the automated-cherry-pick-of-#3691-upstream-release-1.5 branch from 0bea4ad to 6e83158 Compare May 7, 2022 08:47
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #3749 (a5b60ab) into release-1.5 (3d88249) will decrease coverage by 0.17%.
The diff coverage is 78.94%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.5    #3749      +/-   ##
===============================================
- Coverage        60.85%   60.68%   -0.18%     
===============================================
  Files              332      333       +1     
  Lines            28518    39150   +10632     
===============================================
+ Hits             17356    23757    +6401     
- Misses            9266    13394    +4128     
- Partials          1896     1999     +103     
Flag Coverage Δ
e2e-tests 52.46% <77.63%> (?)
kind-e2e-tests 50.18% <79.62%> (+0.36%) ⬆️
unit-tests 41.44% <82.35%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/antctl/antctl.go 66.66% <ø> (ø)
pkg/querier/querier.go 55.00% <ø> (-2.15%) ⬇️
...nt/apiserver/handlers/serviceexternalip/handler.go 51.85% <51.85%> (ø)
...g/agent/controller/serviceexternalip/controller.go 80.82% <93.47%> (-0.04%) ⬇️
pkg/agent/apiserver/apiserver.go 66.66% <100.00%> (-2.90%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 26.31% <0.00%> (-40.36%) ⬇️
pkg/controller/ipam/antrea_ipam_controller.go 48.71% <0.00%> (-31.57%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 61.46% <0.00%> (-29.97%) ⬇️
pkg/controller/egress/controller.go 62.19% <0.00%> (-26.26%) ⬇️
.../registry/networkpolicy/clustergroupmember/rest.go 64.28% <0.00%> (-23.95%) ⬇️
... and 299 more

@xliuxu xliuxu force-pushed the automated-cherry-pick-of-#3691-upstream-release-1.5 branch from 6e83158 to f0d112c Compare May 8, 2022 12:40
Remove the update permission for services/status of antrea-agent
service account. Remove the optimization for ExternalTrafficPolicy
setting to Local cases in ServiceExternalIP feature accordingly.
Introduce "antctl get serviceexternalip" command for the agent to
make checking the assigned Node of external IPs easier.

Signed-off-by: Xu Liu <[email protected]>
@xliuxu xliuxu force-pushed the automated-cherry-pick-of-#3691-upstream-release-1.5 branch from f0d112c to a5b60ab Compare May 8, 2022 12:42
@tnqn
Copy link
Member

tnqn commented May 9, 2022

/test-all

@tnqn
Copy link
Member

tnqn commented May 10, 2022

/skip-networkpolicy
/skip-conformance
manually verified above tests.

@tnqn tnqn merged commit 9d35d65 into antrea-io:release-1.5 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants