Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go version to full version string for Antrea binaries #3182

Merged

Conversation

antoninbas
Copy link
Contributor

While this can currently be obtained at runtime, it requires installing
a new package (e.g. gdb) in the antrea-ubuntu Docker image. See
https://dave.cheney.net/2017/06/20/how-to-find-out-which-go-version-built-your-binary

This will make it easier to figure out which version of Go was used to
build a given version of Antrea.

Signed-off-by: Antonin Bas [email protected]

While this can currently be obtained at runtime, it requires installing
a new package (e.g. gdb) in the antrea-ubuntu Docker image. See
https://dave.cheney.net/2017/06/20/how-to-find-out-which-go-version-built-your-binary

This will make it easier to figure out which version of Go was used to
build a given version of Antrea.

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas antoninbas requested a review from tnqn January 10, 2022 19:17
@antoninbas
Copy link
Contributor Author

root@d133f05c896f:/# antrea-agent --version
antrea-agent version v1.5.0-dev-2ee6ad1d.dirty linux/amd64 go1.17.6

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #3182 (5ada435) into main (2ee6ad1) will decrease coverage by 1.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3182      +/-   ##
==========================================
- Coverage   60.59%   59.47%   -1.12%     
==========================================
  Files         297      297              
  Lines       25434    25434              
==========================================
- Hits        15411    15127     -284     
- Misses       8345     8655     +310     
+ Partials     1678     1652      -26     
Flag Coverage Δ
kind-e2e-tests 45.74% <100.00%> (-1.23%) ⬇️
unit-tests 40.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/version/version.go 46.15% <100.00%> (ø)
pkg/agent/util/net.go 16.32% <0.00%> (-22.45%) ⬇️
pkg/agent/route/route_linux.go 26.88% <0.00%> (-19.80%) ⬇️
pkg/agent/util/ipset/ipset.go 61.53% <0.00%> (-7.70%) ⬇️
pkg/agent/openflow/pipeline.go 67.27% <0.00%> (-6.56%) ⬇️
pkg/agent/metrics/prometheus.go 24.32% <0.00%> (-5.41%) ⬇️
pkg/util/k8s/client.go 46.34% <0.00%> (-4.88%) ⬇️
pkg/agent/proxy/types/groupcounter.go 90.56% <0.00%> (-3.78%) ⬇️
pkg/agent/proxy/proxier.go 57.75% <0.00%> (-2.75%) ⬇️
pkg/controller/traceflow/controller.go 74.07% <0.00%> (-2.12%) ⬇️
... and 9 more

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Jan 11, 2022

/skip-all

@antoninbas antoninbas merged commit 5a6eb01 into antrea-io:main Jan 18, 2022
@antoninbas antoninbas deleted the add-go-version-to-antrea-version-string branch January 18, 2022 22:32
yanjunz97 pushed a commit to yanjunz97/antrea that referenced this pull request Feb 14, 2022
…3182)

While this can currently be obtained at runtime, it requires installing
a new package (e.g. gdb) in the antrea-ubuntu Docker image. See
https://dave.cheney.net/2017/06/20/how-to-find-out-which-go-version-built-your-binary

This will make it easier to figure out which version of Go was used to
build a given version of Antrea.

Signed-off-by: Antonin Bas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants