Add E2E testcase for ANP toService egress rules on multi-cluster Service #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/multi-cluster #3140 +/- ##
=========================================================
+ Coverage 40.21% 40.95% +0.74%
=========================================================
Files 166 184 +18
Lines 20763 22186 +1423
=========================================================
+ Hits 8350 9087 +737
- Misses 11595 12189 +594
- Partials 818 910 +92
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Dyanngg
force-pushed
the
mcs-to-svc-e2e
branch
from
3b8352e to
3ebb5f2
Compare
luolanzone
reviewed
Dec 15, 2021
luolanzone
reviewed
Dec 15, 2021
| func decideProbeResult(stderr string, probeNum int) antreae2e.PodConnectivityMark { | ||
| countConnected := probeNum - strings.Count(stderr, "\n") | ||
| countDropped := strings.Count(stderr, "TIMEOUT") | ||
| // For our UDP rejection cases, agnhost will return: |
There was a problem hiding this comment.
I am wondering is OK to test TCP only Service? we only create and export a nginx service with TCP port. or there is actually no difference?
There was a problem hiding this comment.
I think we should be okay there. ANP on UDP / SCTP traffic is tested extensively in non-multicluster e2e testcases. The major thing to be tested here IMO is that if a policy can be correctly applied to a Service clusterIP exported from another cluster
luolanzone
force-pushed
the
feature/multi-cluster
branch
from
f9e5f48 to
fb5ddfc
Compare
Dyanngg
force-pushed
the
mcs-to-svc-e2e
branch
from
3ebb5f2 to
d6559bb
Compare
Dyanngg
changed the title
Dyanngg
force-pushed
the
mcs-to-svc-e2e
branch
from
d6559bb to
f35915c
Compare
|
/test-multicluster-e2e |
Dyanngg
force-pushed
the
mcs-to-svc-e2e
branch
7 times, most recently
from
6563d58 to
c52470e
Compare
|
/test-multicluster-e2e |
Dyanngg
force-pushed
the
mcs-to-svc-e2e
branch
from
c52470e to
fc6fb08
Compare
|
/test-multicluster-e2e |
Dyanngg
force-pushed
the
mcs-to-svc-e2e
branch
3 times, most recently
from
3804e71 to
f329186
Compare
|
/test-multicluster-e2e |
Dyanngg
force-pushed
the
mcs-to-svc-e2e
branch
from
f329186 to
6ba8108
Compare
|
/test-multicluster-e2e |
luolanzone
approved these changes
Jan 14, 2022
|
Hi @Dyanngg Could you help to resolve those conflicts. I think you can merge it after fix. thanks. |
Signed-off-by: Yang Ding <[email protected]>
Dyanngg
force-pushed
the
mcs-to-svc-e2e
branch
from
6ba8108 to
1941bf8
Compare
|
Solved merge conflicts caused by base patch merge /test-multicluster-e2e |
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Jan 16, 2022
Signed-off-by: Yang Ding <[email protected]>
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Jan 18, 2022
Signed-off-by: Yang Ding <[email protected]>
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Jan 18, 2022
Signed-off-by: Dyanngg <[email protected]>
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Jan 19, 2022
Signed-off-by: Dyanngg <[email protected]>
luolanzone
pushed a commit
that referenced
this pull request
Jan 19, 2022
Signed-off-by: Dyanngg <[email protected]>
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Jan 20, 2022
Signed-off-by: Dyanngg <[email protected]>
luolanzone
pushed a commit
to luolanzone/antrea
that referenced
this pull request
Jan 20, 2022
Signed-off-by: Dyanngg <[email protected]>
yanjunz97
pushed a commit
to yanjunz97/antrea
that referenced
this pull request
Feb 14, 2022
Signed-off-by: Dyanngg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR based on #3124. Only the last commit is relevant to this PR.