-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Antrea Octant plugin to support latest Octant version #2951
Update Antrea Octant plugin to support latest Octant version #2951
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2951 +/- ##
==========================================
- Coverage 60.94% 59.56% -1.38%
==========================================
Files 292 292
Lines 24742 24742
==========================================
- Hits 15079 14738 -341
- Misses 8012 8386 +374
+ Partials 1651 1618 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d10e035
to
474bfa2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @antoninbas,
Thanks so much for helping make the antrea-octant-plugin changes and enhancements!
I was busy working on other problems previously and just found this change.
The change looks great to me.
We can now support Octant 0.24 (latest version). Older versions (up to 0.19) may be supported as well (not tested). By updating the Octant module dependency to v0.24.0, we can also start using the Octant Dashboard client to perform CRUD operations on Antrea CRDs, thus ensuring that the plugin is always using the correct cluster context (see antrea-io#1519). A few other notable things: * We can remove replace directives in the plugin go.mod file (for now?) since K8s dependencies between Antrea and Octant are compatible. * Octant now has a new logging mechanism for plugins but unfortunately it is still buggy so we are not updating our plugin to use it. * The Dashboard client supports a link generator to easily generate links to resources (vmware-archive/octant#2276). Unfortunately I believe that in practice it would make our plugin code more complicated. We can revisit this in the future. Fixes antrea-io#1519 Fixes antrea-io#2315 Fixes antrea-io#2676 Signed-off-by: Antonin Bas <[email protected]>
Signed-off-by: Antonin Bas <[email protected]>
Signed-off-by: Antonin Bas <[email protected]>
Signed-off-by: Antonin Bas <[email protected]>
1140746
to
3fce0af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for making the change!
@mengdie-song thanks for the review |
/skip-all |
Our clusters run antrea v0.13.3 (tanzu 1.4) and will be v1.2.3 (tanzu 1.5). What versions of the octant and the antrea plug-in versions should we use for viewing Tracceflow? See #2676 and related Traceflow issues. |
Hi @wu105, In your case, you can use the latest antrea-octant-plugin with octant v0.24.0 even though you are not using the latest Antrea. Another option will be using antrea-octant-plugin(v0.13.3 or v1.2.3) with octant v0.16.1. |
@mengdie-song Thank you for the information. Octant v0.16.1 and antrea plugin v0.13.3 worked for our clusters running antrea v0.13.3. I did not try Octant v0.16.1 with antrea plugin v1.2.3. I did try Octant v0.24.0 with anrea plugin v1.5.0, v1.4.0, v1.2.3, and v1.3.0, all not working in similar ways: When octant starts, the plugin is loaded, but soon after clicking on the Antrea link on the UI, Octant showed page not found error with the address field displaying http://127.0.0.1:7777/#/antrea-octant-plugin, and the Octant logs show the following: Antrea plugin v1.5.0
antrea plugin 1.4.0, 1.2.3, 1.3.0
|
We can now support Octant 0.24 (latest version). Older versions (up to
0.19) may be supported as well (not tested).
By updating the Octant module dependency to v0.24.0, we can also start
using the Octant Dashboard client to perform CRUD operations on Antrea
CRDs, thus ensuring that the plugin is always using the correct cluster
context (see #1519).
A few other notable things:
since K8s dependencies between Antrea and Octant are compatible.
it is still buggy so we are not updating our plugin to use it.
links to resources
(Add link generator to DashboardClient vmware-archive/octant#2276). Unfortunately I
believe that in practice it would make our plugin code more
complicated. We can revisit this in the future.
Fixes #1519
Fixes #2315
Fixes #2676
Signed-off-by: Antonin Bas [email protected]