Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mellanox/sriovnet version to v1.0.2 #1845

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

Mmduh-483
Copy link
Contributor

This version comes with update for supporting link non uplink representors to PCI device which is needed for hardward offload support for kernel 5.8 and above

@vmwclabot
Copy link

@Mmduh-483, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@Mmduh-483 Mmduh-483 force-pushed the update-sriovnet branch 2 times, most recently from 97aa377 to 535bf9c Compare February 9, 2021 07:40
@vmwclabot
Copy link

@Mmduh-483, VMware has approved your signed contributor license agreement.

@Mmduh-483
Copy link
Contributor Author

/test-hw-offload

@Mmduh-483
Copy link
Contributor Author

/test-networkpolicy
/test-e2e

@Mmduh-483
Copy link
Contributor Author

/test-conformance

@codecov-io
Copy link

codecov-io commented Feb 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@e8f0fb8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1845   +/-   ##
=======================================
  Coverage        ?   42.90%           
=======================================
  Files           ?      199           
  Lines           ?    18008           
  Branches        ?        0           
=======================================
  Hits            ?     7726           
  Misses          ?     9251           
  Partials        ?     1031           
Flag Coverage Δ
e2e-tests 42.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@antoninbas antoninbas requested a review from moshe010 February 9, 2021 19:12
@antoninbas
Copy link
Contributor

@moshe010 @AbdYsn could you take a look at this change?

Copy link
Contributor

@moshe010 moshe010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/s/hardward/hardware
I

@moshe010
Copy link
Contributor

moshe010 commented Feb 9, 2021

@moshe010 @AbdYsn could you take a look at this change?

Sure I will review it.

This version comes with update for supporting link non uplink
representors to PCI device which is needed for hardware offload
support for kernel 5.8 and above

Signed-off-by: Mamduh Alassi <[email protected]>
Copy link
Contributor

@moshe010 moshe010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

/test-all

@antoninbas
Copy link
Contributor

/test-hw-offload

@antoninbas
Copy link
Contributor

/test-networkpolicy

@antoninbas
Copy link
Contributor

/test-all-features-conformance

@antoninbas
Copy link
Contributor

/test-all-features-conformance
/test-windows-conformance

@antoninbas
Copy link
Contributor

/test-all-features-conformance

@antoninbas
Copy link
Contributor

/test-hw-offload

@antoninbas
Copy link
Contributor

Don't know why CI was such a struggle for this PR, but looks good to go

@antoninbas antoninbas merged commit 0c6e616 into antrea-io:main Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants