Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix restart OVS service issue #1756

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

ruicao93
Copy link
Contributor

Service ovs-vswitchd depends on service ovsdb-server.
So the ovsdb-server service cannot be restarted directly
when ovs-vswitchd is running.

Signed-off-by: Rui Cao [email protected]

Service ovs-vswitchd depends on service ovsdb-server.
So the ovsdb-server service cannot be restarted directly
when ovs-vswitchd is running.

Signed-off-by: Rui Cao <[email protected]>
@ruicao93 ruicao93 changed the title [Windows] Fix restart OVS issue [Windows] Fix restart OVS service issue Jan 18, 2021
@ruicao93
Copy link
Contributor Author

/test-all

@codecov-io
Copy link

codecov-io commented Jan 18, 2021

Codecov Report

Merging #1756 (ef54ff4) into master (9d3d10b) will decrease coverage by 4.37%.
The diff coverage is 40.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1756      +/-   ##
==========================================
- Coverage   63.31%   58.94%   -4.38%     
==========================================
  Files         170      192      +22     
  Lines       14250    16371    +2121     
==========================================
+ Hits         9023     9650     +627     
- Misses       4292     5722    +1430     
- Partials      935      999      +64     
Flag Coverage Δ
e2e-tests 43.77% <31.25%> (?)
kind-e2e-tests ?
unit-tests 42.70% <39.58%> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../agent/apiserver/handlers/networkpolicy/handler.go 58.33% <ø> (ø)
...gent/controller/noderoute/node_route_controller.go 60.98% <0.00%> (+14.51%) ⬆️
pkg/agent/interfacestore/types.go 81.81% <0.00%> (+1.81%) ⬆️
pkg/agent/nodeportlocal/k8s/annotations.go 0.00% <0.00%> (ø)
pkg/agent/nodeportlocal/k8s/controller.go 0.00% <0.00%> (ø)
pkg/agent/nodeportlocal/portcache/port_table.go 0.00% <0.00%> (ø)
pkg/agent/nodeportlocal/rules/iptable_rule.go 0.00% <0.00%> (ø)
pkg/agent/nodeportlocal/rules/rules.go 0.00% <ø> (ø)
pkg/agent/nodeportlocal/util/parse_port.go 0.00% <ø> (ø)
pkg/agent/openflow/client.go 70.00% <ø> (+10.13%) ⬆️
... and 165 more

@ruicao93 ruicao93 requested a review from lzhecheng January 18, 2021 09:58
Copy link
Contributor

@lzhecheng lzhecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruicao93 ruicao93 merged commit 741ad6d into antrea-io:master Jan 18, 2021
antoninbas pushed a commit to antoninbas/antrea that referenced this pull request Feb 10, 2021
Service ovs-vswitchd depends on service ovsdb-server.
So the ovsdb-server service cannot be restarted directly
when ovs-vswitchd is running.

Signed-off-by: Rui Cao <[email protected]>
antoninbas pushed a commit that referenced this pull request Feb 11, 2021
Service ovs-vswitchd depends on service ovsdb-server.
So the ovsdb-server service cannot be restarted directly
when ovs-vswitchd is running.

Signed-off-by: Rui Cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants