Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Update the way to check the state of required Windows feature #1741

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

ruicao93
Copy link
Contributor

Hyper-V feature contains multiple components/sub-features. According to
the test, OVS requires "Microsoft-Hyper-V" feature to be enabled.

Signed-off-by: Rui Cao [email protected]

Hyper-V feature contains multiple components/sub-features. According to
the test, OVS requires "Microsoft-Hyper-V" feature to be enabled.

Signed-off-by: Rui Cao <[email protected]>
@ruicao93
Copy link
Contributor Author

/test-all

@codecov-io
Copy link

codecov-io commented Jan 13, 2021

Codecov Report

Merging #1741 (6562f9f) into master (9d3d10b) will increase coverage by 0.26%.
The diff coverage is 69.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
+ Coverage   63.31%   63.58%   +0.26%     
==========================================
  Files         170      189      +19     
  Lines       14250    15907    +1657     
==========================================
+ Hits         9023    10114    +1091     
- Misses       4292     4750     +458     
- Partials      935     1043     +108     
Flag Coverage Δ
e2e-tests 45.79% <56.39%> (?)
kind-e2e-tests 50.92% <56.63%> (-4.47%) ⬇️
unit-tests 41.30% <37.53%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../agent/apiserver/handlers/networkpolicy/handler.go 58.33% <ø> (ø)
...gent/controller/noderoute/node_route_controller.go 60.98% <0.00%> (+14.51%) ⬆️
pkg/agent/proxy/proxier_linux.go 33.33% <ø> (+8.33%) ⬆️
pkg/agent/proxy/service.go 100.00% <ø> (ø)
pkg/agent/proxy/types/groupcounter.go 95.23% <ø> (+0.23%) ⬆️
pkg/agent/proxy/types/types.go 46.66% <ø> (-37.95%) ⬇️
pkg/agent/querier/querier.go 88.46% <ø> (+0.30%) ⬆️
pkg/agent/route/route_linux.go 44.48% <ø> (+0.38%) ⬆️
pkg/agent/stats/collector.go 97.72% <ø> (ø)
pkg/agent/types/networkpolicy.go 83.33% <ø> (ø)
... and 154 more

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruicao93
Copy link
Contributor Author

/test-networkpolicy

@ruicao93 ruicao93 merged commit 0b9d261 into antrea-io:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants