-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set OVS max revalidator delay to 200ms #1584
Set OVS max revalidator delay to 200ms #1584
Conversation
The default value (500ms) causes a K8s upstream conformance test to fail and may increase the risk of users reporting issues if they think SessionAffinity is not implemented properly. Of course there is still a delay before a learned flow is installed in the datapath flow cache and takes effect, but the delay is at least smaller now. This delay cannot be avoided when using the learn action. Reducing the delay to 200ms may have an impact on performance with a large number of datapath flows. Hopefully this impact is not significant. There are other measures we could investigate if we notice performance issues (e.g. reduce the max-idle delay for cached datapath flows to reduce the size of the cache). Fixes antrea-io#1583
Thanks for your PR. The following commands are available:
|
Codecov Report
@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
+ Coverage 63.31% 64.41% +1.09%
==========================================
Files 170 181 +11
Lines 14250 15281 +1031
==========================================
+ Hits 9023 9843 +820
- Misses 4292 4413 +121
- Partials 935 1025 +90
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for root causing the issue.
/test-all |
/test-conformance |
The default value (500ms) causes a K8s upstream conformance test to fail and may increase the risk of users reporting issues if they think SessionAffinity is not implemented properly. Of course there is still a delay before a learned flow is installed in the datapath flow cache and takes effect, but the delay is at least smaller now. This delay cannot be avoided when using the learn action. Reducing the delay to 200ms may have an impact on performance with a large number of datapath flows. Hopefully this impact is not significant. There are other measures we could investigate if we notice performance issues (e.g. reduce the max-idle delay for cached datapath flows to reduce the size of the cache). Fixes #1583
The default value (500ms) causes a K8s upstream conformance test to fail
and may increase the risk of users reporting issues if they think
SessionAffinity is not implemented properly. Of course there is still a
delay before a learned flow is installed in the datapath flow cache and
takes effect, but the delay is at least smaller now. This delay cannot
be avoided when using the learn action.
Reducing the delay to 200ms may have an impact on performance with a
large number of datapath flows. Hopefully this impact is not
significant. There are other measures we could investigate if we notice
performance issues (e.g. reduce the max-idle delay for cached datapath
flows to reduce the size of the cache).
Fixes #1583