Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutate empty Tier set in Antrea-native policies to default tier #1567

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

abhiraut
Copy link
Contributor

Fixes: #1550

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-all-features-conformance: to trigger conformance tests with all alpha features enabled.
  • /skip-all-features-conformance: to skip conformance tests with all alpha features enabled.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #1567 (467de2b) into master (9d3d10b) will decrease coverage by 1.03%.
The diff coverage is 46.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1567      +/-   ##
==========================================
- Coverage   63.31%   62.28%   -1.04%     
==========================================
  Files         170      181      +11     
  Lines       14250    15160     +910     
==========================================
+ Hits         9023     9442     +419     
- Misses       4292     4702     +410     
- Partials      935     1016      +81     
Flag Coverage Δ
kind-e2e-tests 52.70% <44.93%> (-2.68%) ⬇️
unit-tests 40.66% <10.49%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/antrea-agent/agent.go 0.00% <0.00%> (ø)
cmd/antrea-agent/options.go 21.69% <0.00%> (+0.97%) ⬆️
pkg/agent/config/node_config.go 100.00% <ø> (ø)
.../agent/flowexporter/connections/conntrack_linux.go 28.37% <0.00%> (-0.79%) ⬇️
pkg/agent/stats/collector.go 97.72% <ø> (ø)
pkg/controller/networkpolicy/tier.go 90.00% <ø> (ø)
pkg/features/antrea_features.go 16.66% <ø> (ø)
pkg/ovs/openflow/ofctrl_builder.go 60.58% <0.00%> (-1.59%) ⬇️
pkg/ovs/openflow/ofctrl_group.go 48.57% <0.00%> (-4.56%) ⬇️
pkg/ovs/openflow/ofctrl_action.go 51.26% <5.71%> (-10.10%) ⬇️
... and 45 more

@abhiraut abhiraut requested a review from tnqn November 18, 2020 02:17
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An inconsistent comment, otherwise LGTM

pkg/controller/networkpolicy/mutate.go Outdated Show resolved Hide resolved
@abhiraut abhiraut requested a review from tnqn November 18, 2020 18:34
@abhiraut
Copy link
Contributor Author

/test-all

@abhiraut
Copy link
Contributor Author

Merging as the latest commit only addresses a typo in comments and have 2 lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Antrea-native policy without a Tier set in it's spec should have "application" tier set
6 participants