-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent definition of IPFIX field in Kibana #1370
Conversation
Thanks for your PR. The following commands are available:
|
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
=======================================
Coverage 64.36% 64.36%
=======================================
Files 159 159
Lines 12674 12674
=======================================
Hits 8158 8158
+ Misses 3666 3659 -7
- Partials 850 857 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do you know why the entire file has changed, instead of just the field name?
Thanks for reviewing. The file is auto-generated and exported from Kibana web page so I think little formatting difference will cause the whole file change (this happens every time I changes and re-generates this ndjson file). Also I fixed a small grouping function bug in one of the graphs, that may also cause the difference. |
/skip-all |
Fixes #1368
Tested with new Kibana definition file and the dashboard can show destination services related graph:
![Screen Shot 2020-10-13 at 3 39 50 PM](https://user-images.githubusercontent.com/36459546/95923826-2fd3bf00-0d6b-11eb-9034-05779d6b2a35.png)