Use logrotate to rotate OVS log files #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
previously approved these changes
Oct 2, 2020
build/images/scripts/start_ovs
Outdated
Comment on lines
41
to
47
| -*|--*) # unsupported flags | ||
| echo "Error: unsupported flag $1" >&2 | ||
| exit 128 | ||
| ;; | ||
| *) # standalone arguments are not supported | ||
| echo "Error: unsupported argument $1" >&2 | ||
| exit 128 |
There was a problem hiding this comment.
curious about the choice of 128 as the exit code? aren't exit code > 127 typically used for specific purposes?
There was a problem hiding this comment.
Actually forgot to change it. Just changed to 1.
Install logrotate in the OVS Docker image. Enhance start_ovs to run logrotate against the OVS log files in /var/log/openvswitch/ every hour, with two flags: --log_file_max_num and --log_file_max_size to specify the maximum number and maximum size of log files respectively. Update the Antrea deployment YAMLs to set the default value of --log_file_max_num to 4, and the default value of --log_file_max_size to 100MB.
jianjuns
force-pushed
the
ovs-logrotate
branch
from
eb1ee57 to
58673da
Compare
@antoninbas : please help update the OVS image. |
antoninbas
approved these changes
Oct 2, 2020
|
/test-all |
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
Nov 10, 2020
Install logrotate in the OVS Docker image. Enhance start_ovs to run logrotate against the OVS log files in /var/log/openvswitch/ every hour, with two flags: --log_file_max_num and --log_file_max_size to specify the maximum number and maximum size of log files respectively. Update the Antrea deployment YAMLs to set the default value of --log_file_max_num to 4, and the default value of --log_file_max_size to 100MB.
antoninbas
pushed a commit
that referenced
this pull request
Nov 11, 2020
Install logrotate in the OVS Docker image. Enhance start_ovs to run logrotate against the OVS log files in /var/log/openvswitch/ every hour, with two flags: --log_file_max_num and --log_file_max_size to specify the maximum number and maximum size of log files respectively. Update the Antrea deployment YAMLs to set the default value of --log_file_max_num to 4, and the default value of --log_file_max_size to 100MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install logrotate in the OVS Docker image.
Enhance start_ovs to run logrotate against the OVS log files in
/var/log/openvswitch/ every hour, with two flags:
--log_file_max_num and --log_file_max_size to specify the maximum
number and maximum size of log files respectively.
Update the Antrea deployment YAMLs to set the default value of
--log_file_max_num to 4, and the default value of --log_file_max_size
to 100MB.
Fixes: #1328