-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NetworkPolicy metrics API and controlplane stats API #1221
Conversation
Thanks for your PR. The following commands are available:
|
Codecov Report
@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
- Coverage 55.04% 55.01% -0.04%
==========================================
Files 110 113 +3
Lines 10597 10625 +28
==========================================
+ Hits 5833 5845 +12
- Misses 4190 4205 +15
- Partials 574 575 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test-all |
74c253f
to
e1003bc
Compare
4cea2fb
to
a19d7ce
Compare
@jianjuns @antoninbas Because of a conflict with #1258 in types.go and I need both changes to support NetworkPolicyMetrics, I rebased this on #1258, the real change in this PR is a19d7ce. |
d5c16f4
to
d0aab61
Compare
d0aab61
to
9684922
Compare
This PR introduces a control-plane API NodeStatsSummary for stats collection and a public metrics API group including the following APIs: - NetworkPolicyMetrics - AntreaClusterNetworkPolicyMetrics - AntreaNetworkPolicyMetrics
9684922
to
6853a94
Compare
Only rebased on master after #1258 was merged. |
/test-all |
/test-windows-networkpolicy |
3 similar comments
/test-windows-networkpolicy |
/test-windows-networkpolicy |
/test-windows-networkpolicy |
Could you explain why |
@ceclinux please take a look at https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api_changes.md which explains why an internal version is required. Actually it's not a must right now but will be needed once we have another API version. |
Thanks for your reply |
This PR introduces a control-plane API NodeStatsSummary for stats
collection and a public metrics API group including the following APIs:
For #985