Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Resolve OVS dependency for VC 2010 runtime #1099

Merged
merged 1 commit into from
Aug 21, 2020
Merged

[Windows] Resolve OVS dependency for VC 2010 runtime #1099

merged 1 commit into from
Aug 21, 2020

Conversation

ruicao93
Copy link
Contributor

@ruicao93 ruicao93 commented Aug 17, 2020 •
edited
Loading

The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:

  • Remove dependency for VC 2013.
  • Add VC 2010 redistribution which will be installed during the OVS
    installation progress.

This patch updates the OVS package information.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

ruicao93 added a commit to ruicao93/antrea that referenced this pull request Aug 17, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
90b87f2 
OVS currently depends on VC 2010 runtime. Update Install-OVS.ps1
to install the dependency when installing OVS.

Signed-off-by: Rui Cao <[email protected]>
@ruicao93 ruicao93 requested a review from wenyingd August 17, 2020 06:18
ruicao93 added a commit to ruicao93/antrea that referenced this pull request Aug 17, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
61a9117 
OVS depends on VC 2010 runtime. However the VC runtime package
version contained in OVS pacakge provided by Antrea is VC 2013
instead of 2010.

This patch updates Install-OVS.ps1 to check and resolve the
dependency when installing OVS.

Signed-off-by: Rui Cao <[email protected]>
ruicao93 added a commit to ruicao93/antrea that referenced this pull request Aug 17, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
8947c98 
OVS depends on VC 2010 and 2013 runtime. However the VC runtime
package in OVS pacakge provided by Antrea only contains VC 2013

This patch updates Install-OVS.ps1 to check and resolve the
dependencies when installing OVS.

Signed-off-by: Rui Cao <[email protected]>
@ruicao93 ruicao93 closed this Aug 17, 2020
@ruicao93 ruicao93 changed the title [Windows] Resolve OVS dependency for VC 2010 runtime [WIP][Windows] Resolve OVS dependency for VC 2010 runtime Aug 17, 2020
@ruicao93 ruicao93 reopened this Aug 18, 2020
ruicao93 added a commit to ruicao93/antrea that referenced this pull request Aug 18, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
0651e40 
OVS depends on VC 2010 runtime. However the VC runtime redistribution
contained in OVS package provided by Antrea is VC 2013.

This patch updates the OVS package the to resolve the dependency
issue.

Signed-off-by: Rui Cao <[email protected]>
@ruicao93 ruicao93 changed the title [WIP][Windows] Resolve OVS dependency for VC 2010 runtime [Windows] Resolve OVS dependency for VC 2010 runtime Aug 18, 2020
ruicao93 added a commit to ruicao93/antrea that referenced this pull request Aug 18, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
17a3100 
The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
@ruicao93 ruicao93 requested a review from antoninbas August 18, 2020 13:31
@ruicao93
Copy link
Contributor Author

Hi @antoninbas ,
As I mentioned in PR descrition, we need to update the OVS package to fix the VC runtime dependency issue.

Could you help upload following files:

I add sufix to the package file name: 2.13.1-1.1. Do you think it's OK?

Thanks,
Rui

@antoninbas
Copy link
Contributor

@ruicao93 I changed the version in the files to 2.13.1-antrea.1

Here are the links:

I also re-generated the checksum file so it matches the new file name.

ruicao93 added a commit to ruicao93/antrea that referenced this pull request Aug 19, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
55b4ae8 
The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
@ruicao93 ruicao93 changed the title [Windows] Resolve OVS dependency for VC 2010 runtime [WIP][Windows] Resolve OVS dependency for VC 2010 runtime Aug 19, 2020
ruicao93 added a commit to ruicao93/antrea that referenced this pull request Aug 19, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
33304aa 
The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
ruicao93 added a commit to ruicao93/antrea that referenced this pull request Aug 19, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
9aeea97 
The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
ruicao93 added a commit to ruicao93/antrea that referenced this pull request Aug 19, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
a63db54 
The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93 ruicao93 changed the title [WIP][Windows] Resolve OVS dependency for VC 2010 runtime [Windows] Resolve OVS dependency for VC 2010 runtime Aug 19, 2020
@ruicao93
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099)
7ec7d78 
The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
@ruicao93
Copy link
Contributor Author

/test-all

1 similar comment
@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93
Copy link
Contributor Author

/skip-all

1 similar comment
@ruicao93
Copy link
Contributor Author

/skip-all

@ruicao93 ruicao93 merged commit 2c83e9e into antrea-io:master Aug 21, 2020
antoninbas pushed a commit to antoninbas/antrea that referenced this pull request Aug 21, 2020
@ruicao93 @antoninbas
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099) (…
bb332f0 
…antrea-io#1099)

The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
antoninbas pushed a commit that referenced this pull request Aug 21, 2020
@ruicao93 @antoninbas
[Windows] Resolve OVS dependency for VC 2010 runtime (#1099) (#1099)
0e2f32a 
The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
tnqn pushed a commit to tnqn/antrea that referenced this pull request Aug 27, 2020
@ruicao93 @tnqn
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099) (…
6357cf6 
…antrea-io#1099)

The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@ruicao93 @GraysonWu
[Windows] Resolve OVS dependency for VC 2010 runtime (antrea-io#1099) (…
3854eef 
…antrea-io#1099)

The latest OVS pacakge provided by Antrea depends on VC 2010 and
VC 2013 runtime. However the OVS package only contains VC 2013.
Which will cause customer need to install VC 2010 before install
or run OVS.

So we update the OVS package to:
- Remove dependency for VC 2013.
- Add VC 2010 redistribution which will be installed during the OVS
  installation progress.

This patch updates the OVS package information.

Signed-off-by: Rui Cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

@wenyingd wenyingd wenyingd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ruicao93 @antrea-bot @antoninbas @wenyingd @vmwclabot